Repository navigation
task-monitor 5/6: install.sh cargo build + CI Rust job: build and link task-monitor from every loadout installer - #285
Merged
Merged
Conversation
…k task-monitor from every loadout installer New `lib/monitor-install.sh` (`aw_install_monitor`), called from the drift-guarded install-shared-symlinks stanza of all seven loadout installers. With cargo on PATH it runs `cargo build --release` on monitor/ and links ~/.local/bin/task-monitor to the executable cargo's JSON output reports, so CARGO_TARGET_DIR is honoured; a binary built outside the checkout gets a TASK_MONITOR_SNAPSHOT hint. Without cargo it prints one skip line; a failed build warns. Neither fails the install. tests/install_symlinks.bats stubs cargo for every installer test and adds five #277 cases. README, the workflow doc, the seven steering templates and CHANGELOG updated. The CI Rust job moved to #282. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
Spec complianceIssue #277 as amended by its scope-change comment (CI Rust job moved to #282; confirmed present in
Code-review findingsNo correctness blockers.
Nit, optional: the installer's PR body opens with Verdictclean-with-nits (the nit is optional). Merge decision is PM's. |
…locked The installer's `cargo build` now passes `--locked`, as CI does, so a user install builds exactly the committed Cargo.lock instead of silently updating a stale one in the checkout. The retry hint says the same. The stub-cargo test pinning the build args is updated; dropping `--locked` turns it red. README, CHANGELOG and the helper's header comment follow. Review nit on PR #285. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
martin-conur
force-pushed
the
task/monitor-install
branch
from
October 20, 2026 21:02
8af468e to
da3e1d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every loadout's
install.shnow builds thetask-monitorTUI with cargo and links it into~/.local/bin, so you no longer have to build it by hand. If cargo isn't installed it says so in one line and carries on, and a failed build only warns; the bash commands install either way.Closes #277
What changed
lib/monitor-install.sh(aw_install_monitor), called from the drift-guardedinstall-shared-symlinksstanza, so all seven loadouts get it.--message-format=json-render-diagnostics) instead of assumingmonitor/target/release, soCARGO_TARGET_DIR/build.target-dirwork. When that puts the binary outside the checkout, where it can't findbin/task-monitor-snapshotbeside itself, the installer says to exportTASK_MONITOR_SNAPSHOT.Tests
tests/install_symlinks.batsputs a stubcargoonPATHinsetup, so no installer test runs a real release build. Five new tests: build args + link target, one-line skip with no cargo anywhere onPATH, failed build, missing reported executable, outside-the-checkout hint.-xcheck, fail path returning 1, no hint, wrong link target, no--release) each turned at least one test red.claude-gh/install.shagainst a scratchHOMEwith the real cargo; it built, linked andtask-monitor --helpran through the link. Repeated with an outsideCARGO_TARGET_DIR; the hint printed../run_tests.sh: 1466/1466 pass.tools/check-drift.shclean,shellcheck -xclean on the changed files.Docs
README
task-monitorsection,.claude/gh-workflow.md, the seven steering templates, CHANGELOG (with the upgrading note: re-run the loadout'sinstall.sh; notask-initre-run needed).🤖 Generated with Claude Code