fix(security): stop interpolating appPath into shell strings in afterPack - #69
Merged
orange2ai merged 1 commit intoSep 5, 2026
Merged
Conversation
…Pack Run xattr and find through execFileSync with argument arrays so the packaged app path never passes through a shell.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
解决的问题
scripts/afterPack.js将打包路径appPath直接插值进execSync的 shell 字符串，构成命令注入面。修复方式
execSync→execFileSync，以参数数组传递xattr/find的实参，打包路径不再经过任何 shell。行为完全不变（含find -exec sh -c内部通过 find 的 argv 传入文件路径的既有写法）。独立的打包脚本修复，与功能 PR 无关，便于审计。