Stop/StopWithError: Allow single event types - #4
Open
gselzer wants to merge 1 commit into
Open
Conversation
Writing tcspc.Stop(tcspc.WarningEvent(), "my message") is more user-friendly than tcspc.Stop((tcpsc.WarningEvent(),), "my message")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on python examples, I found that I kept wanting to write
but it is currently necessary to write
This PR allows the former to work, in addition to the later, along with some tests.
Note that there are other
Nodes that take multiple event types, such asSelect, but these are variadic arguments. A larger change could unify the behaviors of theseNodetypes withStop/StopWithEvent.