Conversation
tmux matches session targets by prefix, so a default task's session (crabby_<ws>) matched a named task's (crabby_<ws>_<task>) — opening the default task attached to a different one. Target sessions with the '=' exact-match form in has-session/kill-session/attach-session/rename. Also fixes the same collision between workspaces whose names share a prefix (test vs test2). Regression test added. display-message keeps a plain target (its -t is a target-pane, which rejects '='); the dashboard reads attachment from ListSessions, which keys on exact names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.7.2 — bug fix
Opening a task could land on the wrong session. tmux matches session targets by prefix, so a default task's session
crabby_<ws>matched a named task'scrabby_<ws>_<task>— e.g. openingmainattached totest-taskinstead. Crabby now targets sessions with tmux's=exact-match form inhas-session/kill-session/attach-session/rename-window.This also fixes the same latent collision between workspaces whose names share a prefix (e.g.
testandtest2).display-message(Attached/Activity) keeps a plain target — its-tis a target-pane, which rejects=; the dashboard reads attachment fromListSessions, which keys on exact names. Regression test added.