Conversation
install.ps1 skipped the Linux binary whenever crabby was already present in WSL, leaving existing installs stuck on the old version. Always run install.sh, which overwrites in place with the latest release. Also fix a 'tmp: unbound variable' error from install.sh's cleanup trap, which referenced a function-local out of scope under set -u.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installer fixes
Installers are served from
main, so these take effect for real users on merge.Fixed
install.ps1now upgrades an existing install. It used to skip the Linux binary whenevercrabbywas already present in WSL, so re-runningirm ... | iexnever updated it — an install would stay stuck on the old version (this is exactly what happened trying to pick up v0.5.0). It now always runsinstall.sh, which overwrites in place with the latest release.install.shno longer printstmp: unbound variableon exit. The cleanuptrapreferenced a function-local variable that was out of scope by the time it ran underset -u, so the temp dir also leaked.tmpis now script-scoped.Both verified in WSL:
install.shexits cleanly and upgrades 0.4.3 → 0.5.0 in place.