Update device-agent and Symphony MIS setup - #421
Open
sanjujunnuthula wants to merge 9 commits into
Open
sanjujunnuthula wants to merge 9 commits into
sanjujunnuthula wants to merge 9 commits into
Conversation
sanjujunnuthula
commented
Sep 16, 2026
sanjujunnuthula
commented
Contributor
- Removed steps 11 and 12 from device-agent.sh and adjusted the step ordering.
- Added creation of identity and mis folders under:
- /sandbox/poc/device/agent/config/identity
- /sandbox/poc/device/agent/config/mis
- Removed ca-cert.pem and device ECDSA/RSA certificate injection from client scripts, Helm chart, and Docker Compose.
- Added creation of /symphony/api/mis through wfm.sh.
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
sanjujunnuthula
requested review from
nitparihar and
rishabhrai9616
as code owners
September 16, 2026 05:22
spulkit138
reviewed
Sep 16, 2026
spulkit138
reviewed
Sep 16, 2026
spulkit138
reviewed
Sep 16, 2026
spulkit138
reviewed
Sep 16, 2026
spulkit138
reviewed
Sep 16, 2026
spulkit138
reviewed
Sep 16, 2026
Comment on lines
+111
to
+120
| enable_tls_in_symphony_api() { | ||
| cd $HOME | ||
| echo "Enabling tls in symphony API server (will generate certs and seed their settings in symphony-api-margo.json)..." | ||
| collect_certs_info | ||
| generate_server_certs | ||
| # replace value of "tls": false, to "tls": true | ||
| sed -i "s|\"tls\": false|\"tls\": true|" "$HOME/symphony/api/symphony-api-margo.json" | ||
| echo "TLS Config is setup and seeded in symphony-api-margo.json" | ||
| } | ||
| # enable_tls_in_symphony_api() { | ||
| # cd $HOME | ||
| # echo "Enabling tls in symphony API server (will generate certs and seed their settings in symphony-api-margo.json)..." | ||
| # collect_certs_info | ||
| # generate_server_certs | ||
| # # replace value of "tls": false, to "tls": true | ||
| # sed -i "s|\"tls\": false|\"tls\": true|" "$HOME/symphony/api/symphony-api-margo.json" | ||
| # echo "TLS Config is setup and seeded in symphony-api-margo.json" | ||
| # } |
Contributor
Author
There was a problem hiding this comment.
this is required actually for symphony to run on https, my bad, uncommented made it live
Contributor
There was a problem hiding this comment.
please revisit this, as symphony-api-margo.json is also changed and now there are 2 bindings instead of one. I believe this will not work or may result in unknown changes.
spulkit138
reviewed
Sep 16, 2026
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.