ci: keep completed performance reports visible as PRs advance - #1633
Draft
mrousavy wants to merge 1 commit into
Draft
ci: keep completed performance reports visible as PRs advance#1633mrousavy wants to merge 1 commit into
mrousavy wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Performance Report
iOS
All Benchmarks
Android
All Benchmarks
Benchmarking Code Diff Raw measurements: performance-report-1 (JSON artifact). Run 34153977762, attempt 1. Download requires GitHub access. Android: measurements, attempt 1, apps, attempt 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed performance results are currently skipped when the PR's head or base advances before publishing. Keep those results visible until a newer completed report replaces them, with a trusted label linking the exact measured commits and workflow attempt. Closed PRs still skip comments; advanced or superseded reports still skip Bencher history.
Order updates by the source workflow's run number, then attempt. Resolve the existing comment's source through GitHub and require a successful completed attempt from the same PR source repository and branch, including when migrating older comments. An old run finishing late—or being rerun after a newer run—cannot replace newer results. Per-source concurrency with GitHub's documented
queue: maxserializes the read/update sequence without dropping the previous pending publication.Builds on merged #1623, which already shows the report in the run summary. This PR changes the trusted publishing policy; it takes effect after reaching
main. It does not execute artifact code or change the rendered report's contents.Validation: 133 performance-tool tests pass, including completion-order permutations, reruns, repeated publication, advanced/closed PRs, legacy comments, forged ordering metadata and fork/branch provenance. TypeScript, ESLint and diff checks pass. Actionlint 1.7.12 passes with only its unsupported
concurrency.queuediagnostic excluded; a workflow test checks the exact queue configuration against GitHub's documented syntax.