Repository navigation
fix: resolve depot before building in CI - #4
Merged
Merged
Conversation
forge build does not resolve registry dependencies. After the
switch to depot = { registry = "forge", version = "0.2.1" } in
96cadf1, a fresh CI runner has an empty package cache, so depot
is simply absent at build time and every module it provides
reports as unknown (Unknown module `Pool`. Did you mean `Plot`?).
Drop the now-unused "Check out depot" git-clone step (a leftover
from the old path dependency) and add an explicit `forge deps`
step before the build, matching the pattern already used in
bastion's CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depotfrom apath = "../depot"dependency to a registry dependency (registry = "forge", version = "0.2.1").forge builddoes not resolve registry dependencies on its own. On a fresh CI runner the package cache is empty, sodepotis never fetched, and every module it provides (Pool,Connection,Db,Message'sParamText/ParamNull, etc.) reports as unknown — 184 typecheck errors inlib/conduit/storage/postgres.march.git clone ../depotstep is a leftover from the path-dependency era and is no longer referenced byforge.toml.Fix: drop the dead clone step and add an explicit
forge depsstep beforeforge build, matching the pattern already used in bastion's CI (which has a comment describing this exact gotcha).Test plan
forge buildalone (identical error output to the failing run).forge deps && forge buildsucceeds from a clean cache.forge test --releasefrom a clean cache: 242 tests, 0 failures.Fixes the failure at https://github.com/march-language/conduit/actions/runs/31657609540/job/94315408316