Stop mirroring self-host Docker releases to the legacy GHCR namespace - #1
Conversation
Retarget the fork release path so published images land at ghcr.io/marcelruhf/executor (owner-relative name `executor`) and drop the default rhyssullivan GHCR legacy mirror. Co-authored-by: Marcel Ruhf <marcelruhf@users.noreply.github.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe self-host Docker workflow no longer mirrors images to the legacy namespace. Release and deployment documentation now references ChangesSelf-host Docker image namespace
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The release workflow and documentation consistently target the fork’s self-host image, with no unresolved merge-blocking risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Restore the GHCR image name to executor-selfhost so this fork publishes ghcr.io/marcelruhf/executor-selfhost. Owner stays dynamic; the rhyssullivan legacy mirror stays removed. Co-authored-by: Marcel Ruhf <marcelruhf@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dc639fbb17
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Leave public docs and RELEASING.md on the upstream image path. This fork PR only changes the publish workflow. Co-authored-by: Marcel Ruhf <marcelruhf@users.noreply.github.com>
There was a problem hiding this comment.
1 issue found across 4 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="RELEASING.md">
<violation number="1">
P3: The workflow publishes to `ghcr.io/${owner}/executor-selfhost`, where `owner` is the lowercased `GITHUB_REPOSITORY_OWNER` (publish-selfhost-docker.yml lines 75-76), so on this fork the image lands at `ghcr.io/marcelruhf/executor-selfhost` — as the PR's rollout notes state. The new doc line hardcodes `ghcr.io/usefulsoftwareco/executor-selfhost` (the upstream owner), which is wrong for anyone releasing from this fork and contradicts the PR's own rollout note. Use the `ghcr.io/<owner>/executor-selfhost` placeholder so the doc stays correct on both upstream and the fork.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Risk: medium. Dismissing the prior approval because Cubic’s latest review on this head reports 1 unresolved issue, so the required no-findings signal no longer holds. Human review is needed.


Summary
Stop this fork's self-host Docker publish path from mirroring releases to
ghcr.io/rhyssullivan/executor-selfhost.The workflow still derives the owner from
GITHUB_REPOSITORY_OWNERand keeps the image nameexecutor-selfhost. On this fork that publishesghcr.io/marcelruhf/executor-selfhost. Tag scheme is unchanged:vX.Y.Z/X.Y.Z/latestfor stable, and the prerelease equivalents plusbeta.Public docs and
RELEASING.mdare left on the upstream image path. This PR does not edit fork-specific documentation.Linked issue
None. Fork release-image retarget requested separately from the oauth/CIMD work.
What changed
.github/workflows/publish-selfhost-docker.yml— droplegacy_tagsand themirror-legacyjob that pushed toghcr.io/rhyssullivan/executor-selfhostviaGHCR_LEGACY_TOKENNo documentation, changelog, npm package, or local/CI image-name changes.
This branch is cut from current
marcelruhf/executormainonly. It does not reuse or amendfeat/oauth-cimd-deployment-capability.Verification
Diff against
mainis the one workflow file above.Workflow image line remains
image="ghcr.io/${owner}/executor-selfhost"; nolegacy_image,legacy_tags,GHCR_LEGACY_TOKEN, orrhyssullivanremain in that workflow.No changeset: this is fork release-path only, not a published package behavior change.
Scoped review of GHCR /
executor-selfhost/usefulsoftwareco/rhyssullivan/GHCR_LEGACYreferencesbun run format:checkbun run lintbun run typecheckbun run teste2e — not run; no scenario covers GHCR publish target
Checklist
bun run changeset), or this change needs none.After merge: GHCR setup
The first publish from this fork creates
ghcr.io/marcelruhf/executor-selfhost. Confirm:packages: write(the workflow already requests it).GITHUB_TOKENused bypublish-selfhost-docker.ymlcan push to GHCR undermarcelruhf.GHCR_LEGACY_TOKENis no longer used by this workflow and can be removed from repo secrets if nothing else needs it.Summary by cubic
Stops this fork's self-host Docker releases from mirroring to
ghcr.io/rhyssullivan/executor-selfhost; images now publish only to the fork's owner-derived path. After merge, set the new GHCR package visibility to public if anonymous pulls should work;GHCR_LEGACY_TOKENcan be removed from repo secrets if nothing else uses it.mirror-legacyjob and itsGHCR_LEGACY_TOKENusage.vX.Y.Z,X.Y.Z,latest, plus prerelease equivalents andbeta).RELEASING.mdstay on the upstream image path; local build tags, compose image names, and the container name are unchanged.Written for commit 3b9ffe5. Summary will update on new commits.
Summary by CodeRabbit
Documentation
Changes