circus-evaluator: migrate evix 0.3.3 -> 1.0.2#133
Open
NotAShelf wants to merge 5 commits into
Open
Conversation
Replace2 blocking `evaluate_cancellable` + `spawn_blocking` with the v1 async `Session::open(config).await?` + `session.stream()` drain loop. Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I6d77fd62f962d4b2ad9c7f42d8de44356a6a6964
NotAShelf
force-pushed
the
notashelf/push-tmsskmtxkqtx
branch
from
0335dfe to
8cab644
Compare
… count Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ifb96aef86d352dbb2a17bf95210b99796a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: If8a502d8bfc7ef89c6e35f02bd519da46a6a6964
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
evixto the latest version and refactors the Nix evaluation logic to use the new asynchronous streaming API provided byevix. This makes the evaluation code slightly simpler and with my latest changes in nix-bindings the error handling for evaluations is improved slightly.Change-Id: I6d77fd62f962d4b2ad9c7f42d8de44356a6a6964