_get_ani() saves ani_libs.bin every invocation

[alfs]

Shortly after starting a tag collection, I aborted with ctrl-c. Next execution bombed with python errors.

It seems ani_libs.bin is rewritten/saved at every invocation, and I happened to abort in the middle of the save so the tar/bz became corrupt.

So the question is, does ani_libs.bin need to be saved at every invocation? Will it ever be updated after once downloaded?

See

FindMy.py/findmy/reports/anisette.py

Line 339 in 31c7ef7

if self._libs_path is not None:

If it's just a static file, never updated, a simple suggested fix is to check that the file doesn't already exist:

if self._libs_path is not None and not self._libs_path.is_file():

Benefit: no race condition for file corruption and reduced disk wear

[malmeloo]

You're right, it's unnecessary to save it every time. There will be a big update for anisette.py soon, I will fix this when migrating to the new version.

Thanks for reporting!