fix(issue): 让 /issue 按反馈本身澄清,并标明提交时的任务环境 - #3585
Conversation
|
| Filename | Overview |
|---|---|
| packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts | 重写 agent 的澄清与正文组织契约,但环境信息的两条正文指令相互矛盾,可能丢失实际故障环境。 |
| apps/desktop/src/main/github-issue/githubIssueSubmitService.ts | 将自动附加块明确标记为当前任务快照,原有确认、裁剪和提交路径保持不变。 |
| packages/lizi-mcps/src/xdt-helper/capabilities.ts | 同步 issue-tracker capability,使其描述新的按需澄清、图片限制和环境快照语义。 |
| apps/desktop/src/renderer/i18n/locales/zh-CN/common.json | 更新简体中文 /issue 指令和确认卡环境说明,与本次产品语义一致。 |
| apps/desktop/src/renderer/i18n/locales/zh-TW/common.json | 更新繁体中文 /issue 指令和确认卡环境说明。 |
| apps/desktop/src/renderer/i18n/locales/en/common.json | 更新英文 /issue 指令和确认卡环境说明。 |
| apps/desktop/src/renderer/i18n/locales/ja/common.json | 更新日文 /issue 指令和确认卡环境说明。 |
| apps/desktop/src/renderer/i18n/locales/ko/common.json | 更新韩文 /issue 指令和确认卡环境说明。 |
Prompt To Fix All With AI
### Issue 1
packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts:91-93
**故障环境指令相互矛盾**
当用户反馈发生在另一任务、Harness 或模型下的缺陷时,第 91 行要求写入有助定位的 Harness 和模型信息,第 93 行却禁止写入这些环境字段;系统自动附加的又只是当前提交任务快照,导致实际故障环境被遗漏,维护者会得到错误的复现信息。
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(issue): 让 /issue 按反馈本身澄清,并标明提交时的任务环境" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ab1bb734e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 3 条 review conversation 没 resolve(packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts / apps/desktop/src/main/github-issue/githubIssueSubmitService.ts),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 51127f9510
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 2 条 review conversation 没 resolve(apps/desktop/src/main/github-issue/githubIssueSubmitService.ts / apps/desktop/src/renderer/i18n/locales/en/common.json),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
不要套固定问卷;普通建议和环境无关的反馈不必追问 Harness / 模型 / 推理强度。 自动附加的环境块改称「提交时的任务环境」,避免被当成出问题的那个运行时。 Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
GitHub 环境块改为「仅代表提交时快照,不一定是故障环境」。 确认卡 envLine 五语标成提交客户端环境,runtimeLine 仍标当前任务的 Harness / 模型。 Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
cc06bd2 to
08b89d2
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08b89d27ff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
恢复提交时自动附加的披露,并保留客户端环境与当前 Session 的来源区分。英文 runtimeLine 按术语表改为 this session。 Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
MagicLizi
left a comment
There was a problem hiding this comment.
代码重审通过:当前 head 未发现 P0/P1。/issue 按反馈本身澄清,确认卡与 GitHub 环境块区分提交客户端环境和当前任务快照。
|
确认卡把客户端环境和当前任务拆开写,反馈本身也不再被问卷带着跑。谢谢。 |
这次改了什么
摘要
/issue提交流程不再套固定问卷。Agent 按这条反馈本身判断该问什么、正文怎么组织:普通建议不必按缺陷来问,和环境无关不必追问 Harness / 模型 / 推理强度。自动附在 GitHub issue 末尾的环境块改称「提交时的任务环境」,并写明这是当前任务快照,避免被当成「出问题的那个运行时」。变更类型
feat新功能fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
/issue产出质量;不绑定公开 issuesubmit_github_issue工具描述与 body schema:原则约束(隐私、不猜、不假称截图、环境由系统附加),澄清深度交给 agentissue-trackercapability 同步/issue注入文案与确认卡envLine/runtimeLine/issue对话不再按固定章节追问UI 变化
确认卡仍是原布局,只改既有说明文案(五语)。无新组件、无间距/配色变化。
怎么验证的
自动验证
手工验证
不涉及。未启动 Desktop 实机走一遍
/issue确认卡。未执行的验证
pnpm test:unit(相关门禁已覆盖 desktop 全量 + 受影响的@cindy/mcps单测)/issue提交流程风险
风险分类
submit_github_issue工具描述、/issue注入文案与 GitHub issue 环境块标题。Agent 澄清风格会变,不改确认门、脱敏或提交身份。影响与回滚
/issue对话澄清、确认卡环境说明、提交到 GitHub 的环境块标题提交前检查
git commit -s,见 DCO)