Skip to content

fix(issue): 让 /issue 按反馈本身澄清,并标明提交时的任务环境 - #3585

Merged
MagicLizi merged 4 commits into
mainfrom
dash/issue-suggest-problem-model
Aug 29, 2026
Merged

fix(issue): 让 /issue 按反馈本身澄清,并标明提交时的任务环境#3585
MagicLizi merged 4 commits into
mainfrom
dash/issue-suggest-problem-model

Conversation

@dashhuang

Copy link
Copy Markdown
Member

这次改了什么

摘要

/issue 提交流程不再套固定问卷。Agent 按这条反馈本身判断该问什么、正文怎么组织:普通建议不必按缺陷来问,和环境无关不必追问 Harness / 模型 / 推理强度。自动附在 GitHub issue 末尾的环境块改称「提交时的任务环境」,并写明这是当前任务快照,避免被当成「出问题的那个运行时」。

变更类型

  • feat 新功能
  • fix 缺陷修复
  • refactor / perf 重构或性能优化
  • docs / test / chore 文档、测试或工程维护
  • 其他:

范围

  • 关联 Issue / 需求:内部优化 /issue 产出质量;不绑定公开 issue
  • 本 PR 包含:
    • submit_github_issue 工具描述与 body schema:原则约束(隐私、不猜、不假称截图、环境由系统附加),澄清深度交给 agent
    • issue-tracker capability 同步
    • 五语 /issue 注入文案与确认卡 envLine / runtimeLine
    • GitHub issue 环境块标题改为「提交时的任务环境」,并加快照说明
  • 明确不包含:截图上传、重复 issue 检索、GitHub 网页模板、确认卡新字段
  • 用户可见变化:确认卡环境说明改称「提交时的任务环境」;/issue 对话不再按固定章节追问
  • 是否存在 breaking change:无

UI 变化

确认卡仍是原布局,只改既有说明文案(五语)。无新组件、无间距/配色变化。

  • 引用的设计规范:DESIGN.md(沿用确认卡既有布局与语义 token,不新增组件或改间距/配色);session 面向用户称「任务」,ja/ko 用 セッション / 세션

怎么验证的

自动验证

pnpm --filter desktop run typecheck
结果:通过

pnpm test:unit:related
结果:PASS apps/desktop unit (106.2s);PASS packages/lizi-mcps unit (4.2s)
(common.json 触发 desktop 全量单测)

pnpm --filter @cindy/mcps exec vitest run src/__tests__/submitGithubIssueTool.test.ts src/__tests__/getCapabilitiesTool.test.ts
结果:16 passed

pnpm --filter desktop exec vitest run src/main/github-issue/__tests__/githubIssueSubmitService.test.ts src/main/github-issue/__tests__/issueConfirmBridge.test.ts src/renderer/features/cc-agent/__tests__/IssueConfirmCard.test.tsx src/renderer/__tests__/regionCode.consistency.test.ts
结果:56 passed

pnpm check:i18n
结果:zh-CN / zh-TW / en / ja / ko 共 8377 个 key 全部一致

pnpm check:dco
结果:1 commit signed off — range 2310a133..3ab1bb73

手工验证

不涉及。未启动 Desktop 实机走一遍 /issue 确认卡。

未执行的验证

  • 未跑仓库根全量 pnpm test:unit(相关门禁已覆盖 desktop 全量 + 受影响的 @cindy/mcps 单测)
  • 未做 Desktop 实机 /issue 提交流程

风险

风险分类

  • 无已知风险
  • SQLite / migration
  • system prompt
  • 协议兼容
  • 权限 / 安全 / 用户数据
  • 存量插件兼容(批准状态 / 指纹 / manifest 校验 / 安装布局 / 包格式)
  • 原生层 / fingerprint / OTA
  • 跨平台差异
  • 其他:改了模型可见的 submit_github_issue 工具描述、/issue 注入文案与 GitHub issue 环境块标题。Agent 澄清风格会变,不改确认门、脱敏或提交身份。

影响与回滚

  • 影响范围:/issue 对话澄清、确认卡环境说明、提交到 GitHub 的环境块标题
  • 回滚 / 降级方式:revert 本 PR

提交前检查

  • 已 review 完整 diff
  • 每个 commit 都带 DCO 签名(git commit -s,见 DCO
  • UI 改动已在「UI 变化」注明引用的设计规范章节(不涉及 UI 则跳过)
  • 未提交凭证、令牌或授权文件
  • 已补充必要文档
  • 已确认测试结果或说明未执行原因

@dashhuang
dashhuang requested a review from a team as a code owner August 28, 2026 17:04
@greptile-apps

greptile-apps Bot commented Aug 28, 2026

Copy link
Copy Markdown

Greptile Summary

本 PR 调整 /issue 的模型指令,使澄清问题和正文结构由反馈本身决定,并把自动附加的信息明确标为提交时的当前任务快照。

  • 更新 submit_github_issue 的工具描述、字段说明和 capability 文案
  • 同步五种语言的 /issue 注入指令及确认卡环境标签
  • 更新 GitHub Issue 环境块标题、说明和相关测试

Confidence Score: 4/5

合并前应消除正文 schema 中关于实际故障环境的矛盾指令,否则生成的 Issue 可能只记录提交任务而非故障发生时的环境。

自动环境块只记录当前提交任务,但工具正文说明同时要求保留有助定位的 Harness/模型并禁止写入这些字段,导致另一运行环境中的缺陷可能丢失关键复现信息。

Files Needing Attention: packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts

Important Files Changed

Filename Overview
packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts 重写 agent 的澄清与正文组织契约,但环境信息的两条正文指令相互矛盾,可能丢失实际故障环境。
apps/desktop/src/main/github-issue/githubIssueSubmitService.ts 将自动附加块明确标记为当前任务快照,原有确认、裁剪和提交路径保持不变。
packages/lizi-mcps/src/xdt-helper/capabilities.ts 同步 issue-tracker capability,使其描述新的按需澄清、图片限制和环境快照语义。
apps/desktop/src/renderer/i18n/locales/zh-CN/common.json 更新简体中文 /issue 指令和确认卡环境说明,与本次产品语义一致。
apps/desktop/src/renderer/i18n/locales/zh-TW/common.json 更新繁体中文 /issue 指令和确认卡环境说明。
apps/desktop/src/renderer/i18n/locales/en/common.json 更新英文 /issue 指令和确认卡环境说明。
apps/desktop/src/renderer/i18n/locales/ja/common.json 更新日文 /issue 指令和确认卡环境说明。
apps/desktop/src/renderer/i18n/locales/ko/common.json 更新韩文 /issue 指令和确认卡环境说明。
Prompt To Fix All With AI
### Issue 1
packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts:91-93
**故障环境指令相互矛盾**

当用户反馈发生在另一任务、Harness 或模型下的缺陷时,第 91 行要求写入有助定位的 Harness 和模型信息,第 93 行却禁止写入这些环境字段;系统自动附加的又只是当前提交任务快照,导致实际故障环境被遗漏,维护者会得到错误的复现信息。

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix(issue): 让 /issue 按反馈本身澄清,并标明提交时的任务环境" | Re-trigger Greptile

Comment thread packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ab1bb734e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/src/main/github-issue/githubIssueSubmitService.ts
Comment thread packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts Outdated
@MagicLizi

Copy link
Copy Markdown
Contributor

@dashhuang 👋 这个 PR 还有 3 条 review conversation 没 resolve(packages/lizi-mcps/src/xdt-helper/submit_github_issue.ts / apps/desktop/src/main/github-issue/githubIssueSubmitService.ts),auto-review 因此暂时跳过、没法继续审查 / 合并。

如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。

@MagicLizi MagicLizi added the status:ci-failed CI 失败(review-pr 自动维护,仅展示) label Aug 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 51127f9510

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/src/main/github-issue/githubIssueSubmitService.ts Outdated
Comment thread apps/desktop/src/renderer/i18n/locales/en/common.json Outdated
@MagicLizi

Copy link
Copy Markdown
Contributor

@dashhuang 👋 这个 PR 还有 2 条 review conversation 没 resolve(apps/desktop/src/main/github-issue/githubIssueSubmitService.ts / apps/desktop/src/renderer/i18n/locales/en/common.json),auto-review 因此暂时跳过、没法继续审查 / 合并。

如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。

不要套固定问卷;普通建议和环境无关的反馈不必追问 Harness / 模型 / 推理强度。
自动附加的环境块改称「提交时的任务环境」,避免被当成出问题的那个运行时。

Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
GitHub 环境块改为「仅代表提交时快照,不一定是故障环境」。
确认卡 envLine 五语标成提交客户端环境,runtimeLine 仍标当前任务的 Harness / 模型。

Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
@dashhuang
dashhuang force-pushed the dash/issue-suggest-problem-model branch from cc06bd2 to 08b89d2 Compare August 29, 2026 07:33
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-29T07:57:35.897775Z 9db3742 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08b89d27ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/desktop/src/renderer/i18n/locales/en/common.json Outdated
Comment thread apps/desktop/src/renderer/i18n/locales/en/common.json Outdated
恢复提交时自动附加的披露,并保留客户端环境与当前 Session 的来源区分。英文 runtimeLine 按术语表改为 this session。

Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
@MagicLizi MagicLizi removed the status:ci-failed CI 失败(review-pr 自动维护,仅展示) label Aug 29, 2026

@MagicLizi MagicLizi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码重审通过:当前 head 未发现 P0/P1。/issue 按反馈本身澄清,确认卡与 GitHub 环境块区分提交客户端环境和当前任务快照。

@MagicLizi
MagicLizi merged commit d2873eb into main Aug 29, 2026
18 checks passed
@MagicLizi
MagicLizi deleted the dash/issue-suggest-problem-model branch August 29, 2026 08:54
@MagicLizi

Copy link
Copy Markdown
Contributor

确认卡把客户端环境和当前任务拆开写,反馈本身也不再被问卷带着跑。谢谢。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants