fix(desktop): 锁定 Splash 品牌布局避免启动瞬间缩小 - #3584
Conversation
|
| Filename | Overview |
|---|---|
| apps/desktop/src/renderer/components/login/LoginBrandStage.tsx | 根据 handoff 布局选择 Splash 或登录几何，并改为只淡出品牌内容、保留不透明背景。 |
| apps/desktop/src/renderer/components/login/loginScale.ts | 新增 Splash 布局和短窗口覆盖余量，但该余量会使高层登录面板覆盖字标底部。 |
| apps/desktop/src/renderer/components/splash/SplashScreen.tsx | 在 Splash 到达 done/skipped 后单次上报退场完成，用于延后品牌布局切换。 |
| apps/desktop/src/renderer/contexts/LoginHandoffContext.tsx | 新增 splashExitCompleted 状态及 brandLayout 派生逻辑，认证品牌退场阶段继续锁定 Splash 构图。 |
| apps/desktop/src/renderer/contexts/tests/LoginHandoffContext.test.tsx | 覆盖新布局切换时序和内容层淡出，但未验证短窗口中登录面板不会遮挡字标。 |
| apps/desktop/src/renderer/components/login/tests/loginScale.test.ts | 验证允许覆盖后的立绘底边和缩放比例，但断言仅使用整体底边，遗漏了字标可见性。 |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Splash 显示] --> B[Splash 开始淡出]
B --> C[保持 Splash 品牌布局]
C --> D[Splash 完成并卸载]
D --> E{认证分支}
E -- 未登录 --> F[切换登录布局并显示面板]
E -- 已登录 --> G[品牌内容淡出]
G --> H[卸载品牌覆盖层并显示主界面]
Prompt To Fix All With AI
### Issue 1
apps/desktop/src/renderer/components/login/loginScale.ts:135-137
**覆盖边界包含字标**
当未登录窗口高度不超过 768px 且存在底部预留时，这里允许登录面板覆盖整个品牌块底部 64px；字标距该底边仅 18 个设计单位，并且面板层级高于品牌层，因此需要用满覆盖量的短窗口会让面板遮住 Cindy 字标底部。
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(desktop): lock splash brand layout d..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d776585377
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 2 条 review conversation 没 resolve(apps/desktop/src/renderer/components/login/loginScale.ts),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
MagicLizi
added
status:ci-failed
|
命中 UI 路径(apps/desktop/src/renderer/components/login/LoginBrandStage.tsx / apps/desktop/src/renderer/components/login/loginScale.ts / apps/desktop/src/renderer/components/splash/SplashScreen.tsx 等)但 description 未附界面效果证据——建议补充改动后效果:截图/录屏,或改动后界面的 HTML 页面(```html 代码块、.html 附件或在线预览链接),便于确认界面符合 DESIGN.md 设计规范 |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cef457999
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 3 条 review conversation 没 resolve(apps/desktop/src/renderer/components/login/loginScale.ts / apps/desktop/src/renderer/components/splash/SplashScreen.tsx),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
|
@codex review |
MagicLizi
added
status:awaiting-bot-review
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8011411f1d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 93381ca5a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 1 条 review conversation 没 resolve(apps/desktop/src/renderer/components/login/LoginBrandStage.tsx),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
MagicLizi
added
status:ci-failed
93381ca to
f64ab31
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f64ab31895
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 942f3caa73
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32c0823235
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MagicLizi
added
status:awaiting-bot-review
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 02a1ea50ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@dashhuang 👋 这个 PR 还有 1 条 review conversation 没 resolve(apps/desktop/src/renderer/contexts/LoginHandoffContext.tsx),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
MagicLizi
added
status:ci-failed
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
b15900a to
bf0ee44
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf0ee447c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
MagicLizi
added
status:awaiting-bot-review
|
@dashhuang 👋 这个 PR 还有 1 条 review conversation 没 resolve(apps/desktop/src/renderer/components/splash/SplashScreen.tsx),auto-review 因此暂时跳过、没法继续审查 / 合并。 如果你已经按评论改完或回应了,请到对应 thread 上点 Resolve conversation;全部 resolve 后,下一轮 auto-review 会自动重新审查这个 PR。 |
Signed-off-by: Dash <125997726+dashhuang@users.noreply.github.com>
MagicLizi
added
status:ci-failed
MagicLizi
added
status:ci-running
codexProxyHost.test.ts 首条用例一直在替整个 SUT 模块图的 Vitest 冷 transform 买单:Linux CI 分片实测超默认 5s(#3584 两次复现),抬到 15s 后 Windows 分片又超 15s。这笔成本属于环境冷启动,不属于断言 —— 挪进 带独立 60s 超时的文件级 beforeAll,首条用例退回默认超时。 Signed-off-by: Lizi <jiali@magiclizi.com>
MagicLizi
left a comment
MagicLizi
left a comment
There was a problem hiding this comment.
审查通过：Splash 品牌几何锁定到面板入场再切登录布局，动效用 transform/opacity 与既有 420ms panel 时序，reduced-motion 走终态。
MagicLizi
left a comment
MagicLizi
left a comment
There was a problem hiding this comment.
代码重审通过：Splash 布局锁定到淡出完成再切登录构图，无 P0/P1。
|
合了。启动那一下品牌块忽然缩小一直挺扎眼，现在淡出结束才切登录构图，冷启动看起来稳多了。 |
2 participants
这次改了什么
摘要
修复 Desktop 启动交接时品牌图在淡出瞬间缩小的问题。Splash 淡出期间保持当前构图，只有 Splash 实际可卸载后才上报退场完成并切换到登录布局；未登录短窗口的这次几何切换按既有
shift时序（650ms / 对应 easing）做一次平滑 transform 过渡，普通 resize 不挂常驻 transition；已登录路径没有登录面板，因此不再使用登录面板的 124px 底部预留。已登录品牌层的卸载计时与--splash-fade-duration的 400ms 实际淡出时长对齐，避免淡出后额外留下纯色遮罩。变更类型
fix缺陷修复refactor/perf重构或性能优化docs/test/chore文档、测试或工程维护范围
UI 变化
docs/design-rules/DESIGN.md §10（Light / Dark 双模式交付门槛）；§14.4（功能性动效与 reduced-motion 约束）；§16.2（登录链路设计规则与品牌画布几何）；§16.3（LoginPanel / Splash 共用面板但保持独立高度）。怎么验证的
自动验证
手工验证
macOS Global 开发版从本 worktree 启动并通过
DESKTOP_DEV_VERDICT=ready；用户已确认启动画面比例正常。当前实例 root 为/Users/dash/Code/Cindy/cindy-fix-splash-brand-layout。未执行的验证
完整
run-unit-gate.sh已执行；apps/desktop unit通过（136.3s），但packages/maker-core的 PI 集成测试有 2 项失败（1 项 60 秒超时、1 项临时配置目录数量断言）。该包未被本 PR 修改，失败与本次 Desktop UI 改动无文件交集，详见 gate 日志。风险
风险分类
影响与回滚
60206e099、30654b240、f07b37302、784d4a2c2、f64ab3189）即可恢复原实现；不涉及数据迁移或持久化格式。提交前检查
git commit -s，见 DCO）