Skip to content

fix(cindy-art): prioritize Art media handling - #100

Merged
GaoWeiLiuXD merged 3 commits into
makecindy:mainfrom
GaoWeiLiuXD:fix/art-media-agent-guidance
Aug 31, 2026
Merged

fix(cindy-art): prioritize Art media handling#100
GaoWeiLiuXD merged 3 commits into
makecindy:mainfrom
GaoWeiLiuXD:fix/art-media-agent-guidance

Conversation

@GaoWeiLiuXD

@GaoWeiLiuXD GaoWeiLiuXD commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

What changed / 改了什么

  • 提高 Art 的召回优先级:用户需要生成或编辑图片、生成视频且未明确指定其他媒体渠道时,优先选择 Art。
  • 同步 zh-CN、en、ja、ko 四种语言的 whenToUse
  • 在 Art 的四个工具描述、四种 locale 文案和运行时返回中明确指导 Agent:受管 URI 可直接展示、改图和附件交接;图片只展示一次;仅在用户明确询问本地路径时调用 resolve_local_path;禁止猜测路径或扫描磁盘。
  • 基于最新官方 main 保留订阅专属模型转发修复,并将 Art 版本从 1.13.4 递增到 1.13.5。
  • minCindyVersion 从 0.1.56 提高到 0.1.68,确保依赖客户端媒体展示、受管路径解析和去重能力的 Agent 指引只下发给兼容客户端。

Why / 为什么

默认生图请求可能被下游 harness 自带图片工具抢占,从而绕过用户在 Art 中配置的模型;同时,工具结果自动渲染与 Agent 最终回复重复嵌图会造成同一图片展示两次。Agent 在只拿到受管 URI 时还可能误以为必须扫描磁盘才能找到源文件。

本改动把 Art 设为未指定其他渠道时的首选,并把展示、改图与显式路径查询三种语义写清。

Checklist

  • Reviewed the complete diff — no credentials, tokens, authorization codes,
    real user data, unrelated generated files, or node_modules.
    已 review 完整 diff —— 无凭证、令牌、授权码、真实用户数据、无关生成文件或 node_modules
  • ghost.json declares only capabilities actually used (network hosts /
    slots / secrets); any new capability is justified in this PR description.
    ghost.json 只声明实际用到的能力;本 PR 未新增 capability。
  • Tools with irreversible external side effects handle every failure path.
    本插件四个工具只整理参数,不直接执行不可逆外部动作。
  • Every changed tool description still matches actual behavior; SKILL.md
    and settings copy stay consistent with it.
    四个 tools[].description 已与运行时 result note 同步;parameters 未修改。
  • Bumped ghost.json version to a SemVer greater than main.
  • minCindyVersion 已提高到 0.1.68,并在精确的 Cindy 0.1.68 上安装验证真实 .cindy 包。
  • 不涉及新插件。
  • Ran localization checks.
  • 不涉及 src/node/worker.cjs
  • 未新增或升级内嵌依赖。
  • Every commit is signed off with git commit -s.

Tool declaration changes / 工具声明改动

四个 tools[].description 及 zh-CN、en、ja、ko 文案已同步受管 URI 展示、复用、附件交接和按需路径解析契约;parameters 未修改。顶层 whenToUse 使未显式选择其他媒体渠道的生图、改图和视频请求优先召回 Art,运行时 result note 保持同一处理语义。

Verification / 验证

node --test .tests/localization.test.mjs .tests/provisioning.test.mjs .tests/publish-workflows.test.mjs .tests/cindy-art.test.mjs
结果:21 passed

BASE_SHA=$(git rev-parse upstream/main) HEAD_SHA=$(git rev-parse HEAD) node --test .tests/plugin-contract.test.mjs
结果:2 passed

.github/scripts/package-plugin.sh cindy-art /private/tmp/cindy-art-pr100.fwJWQG/cindy-art.cindy
结果:通过;归档包含 LICENSE / NOTICE / TRADEMARKS,包内 ghost.json 为 version=1.13.5、minCindyVersion=0.1.68;SHA-256 25d26ba34dd68e7fd3ea5c7f91ad2d81c1b7de808ff30ff37ac9c3e130ec3874

本地 macOS Desktop 0.1.68 E2E:真实 .cindy 包安装通过;普通“生成一张夏天的图”命中 Art → Cindy Core media,没有调用 harness 自带 image tool;结果只展示一次;显式询问路径时调用 resolve_local_path;后续改图直接复用原始 cindy-media:// 地址。

Sensitive changes / 敏感变更

仅将 minCindyVersion 从 0.1.56 提高到 0.1.68,并已完成精确版本安装验证。未改依赖、vendor、二进制资源、OAuth/API scope、凭证或鉴权边界、network/secret/slot/tool/Node capability、provisioning audience 或其它发布策略。

Signed-off-by: liugaowei <liugaowei@xd.com>
@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Greptile Summary

本 PR 提高 Art 对未指定其他媒体渠道的图片与视频请求的召回优先级,并完善受管媒体 URI 的展示、复用、附件交接和本地路径解析指导。

  • 同步更新 zh-CN、en、ja、ko 四种语言的 whenToUse 与工具说明
  • 更新运行时结果说明,避免重复展示图片或误扫本地磁盘
  • 将插件版本提升至 1.13.5,并将最低 Cindy 版本提升至 0.1.68
  • 增加对应的 manifest、本地化和结果说明测试

Confidence Score: 5/5

当前未发现阻断性故障,PR 看起来可以安全合并。

没有阻断性故障仍然存在。

Important Files Changed

Filename Overview
cindy-art/ghost.json 更新召回优先级、受管媒体处理契约、版本号和最低客户端版本,四个工具的指导保持一致。
cindy-art/main.js 扩充返回给 Agent 的媒体展示、复用、附件交接及显式路径解析说明,未改变请求构造逻辑。
.tests/cindy-art.test.mjs 增加版本、最低客户端版本、四语言媒体指导和运行时结果说明的覆盖。
cindy-art/locales/en.json 同步英文召回优先级与受管媒体处理语义。
cindy-art/locales/ja.json 同步日文召回优先级与受管媒体处理语义。
cindy-art/locales/ko.json 同步韩文召回优先级与受管媒体处理语义。
cindy-art/locales/zh-CN.json 同步简体中文召回优先级与受管媒体处理语义。

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  U[用户媒体请求] --> A[Art 工具]
  A --> R[整理模型与创作参数]
  R --> C[Cindy Core media]
  C --> M[受管媒体 URI]
  M --> D[直接展示或复用]
  M --> T[通过 attachments 交接]
  M -->|用户明确询问本地路径| P[resolve_local_path]
Loading

Reviews (3): Last reviewed commit: "fix(cindy-art): align media result guida..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot previously approved these changes Aug 27, 2026
@nanaco666

Copy link
Copy Markdown
Collaborator

当前合并门禁未通过(head 51bdf99

新 PR 已进入巡检,当前状态:

  • Greptile 已对当前 head 复审为 5/5(Last reviewed commit 即当前 head)并自动 Approve;无未解决 review thread;Repository-wide gates、changed-plugin packaging、DCO 全部 success。
  • 尚无维护者人工 approving review(当前 approving review 仅来自 Greptile 自动审批;按仓库规则自动审批不替代人工门禁)。

请完成人工 review 后正式 Approve;完成前请勿合并。

Signed-off-by: liugaowei <liugaowei@xd.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-31T07:09:38.208722Z 121c381 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

greptile-apps[bot]
greptile-apps Bot previously approved these changes Aug 31, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a9ed7c6636

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread cindy-art/ghost.json
Comment thread cindy-art/main.js
Signed-off-by: liugaowei <liugaowei@xd.com>
@GaoWeiLiuXD
GaoWeiLiuXD merged commit 6078609 into makecindy:main Aug 31, 2026
4 checks passed
@GaoWeiLiuXD
GaoWeiLiuXD deleted the fix/art-media-agent-guidance branch August 31, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants