fix(cindy-art): prioritize Art media handling - #100
Conversation
Signed-off-by: liugaowei <liugaowei@xd.com>
|
| Filename | Overview |
|---|---|
| cindy-art/ghost.json | 更新召回优先级、受管媒体处理契约、版本号和最低客户端版本,四个工具的指导保持一致。 |
| cindy-art/main.js | 扩充返回给 Agent 的媒体展示、复用、附件交接及显式路径解析说明,未改变请求构造逻辑。 |
| .tests/cindy-art.test.mjs | 增加版本、最低客户端版本、四语言媒体指导和运行时结果说明的覆盖。 |
| cindy-art/locales/en.json | 同步英文召回优先级与受管媒体处理语义。 |
| cindy-art/locales/ja.json | 同步日文召回优先级与受管媒体处理语义。 |
| cindy-art/locales/ko.json | 同步韩文召回优先级与受管媒体处理语义。 |
| cindy-art/locales/zh-CN.json | 同步简体中文召回优先级与受管媒体处理语义。 |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
U[用户媒体请求] --> A[Art 工具]
A --> R[整理模型与创作参数]
R --> C[Cindy Core media]
C --> M[受管媒体 URI]
M --> D[直接展示或复用]
M --> T[通过 attachments 交接]
M -->|用户明确询问本地路径| P[resolve_local_path]
Reviews (3): Last reviewed commit: "fix(cindy-art): align media result guida..." | Re-trigger Greptile
当前合并门禁未通过(head 51bdf99)新 PR 已进入巡检,当前状态:
请完成人工 review 后正式 Approve;完成前请勿合并。 |
Signed-off-by: liugaowei <liugaowei@xd.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9ed7c6636
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: liugaowei <liugaowei@xd.com>
What changed / 改了什么
whenToUse。resolve_local_path;禁止猜测路径或扫描磁盘。main保留订阅专属模型转发修复,并将 Art 版本从 1.13.4 递增到 1.13.5。minCindyVersion从 0.1.56 提高到 0.1.68,确保依赖客户端媒体展示、受管路径解析和去重能力的 Agent 指引只下发给兼容客户端。Why / 为什么
默认生图请求可能被下游 harness 自带图片工具抢占,从而绕过用户在 Art 中配置的模型;同时,工具结果自动渲染与 Agent 最终回复重复嵌图会造成同一图片展示两次。Agent 在只拿到受管 URI 时还可能误以为必须扫描磁盘才能找到源文件。
本改动把 Art 设为未指定其他渠道时的首选,并把展示、改图与显式路径查询三种语义写清。
Checklist
real user data, unrelated generated files, or
node_modules.已 review 完整 diff —— 无凭证、令牌、授权码、真实用户数据、无关生成文件或
node_modules。ghost.jsondeclares only capabilities actually used (network hosts /slots / secrets); any new capability is justified in this PR description.
ghost.json只声明实际用到的能力;本 PR 未新增 capability。本插件四个工具只整理参数,不直接执行不可逆外部动作。
descriptionstill matches actual behavior; SKILL.mdand settings copy stay consistent with it.
四个
tools[].description已与运行时 result note 同步;parameters 未修改。ghost.jsonversionto a SemVer greater thanmain.minCindyVersion已提高到 0.1.68,并在精确的 Cindy 0.1.68 上安装验证真实.cindy包。src/或node/worker.cjs。git commit -s.Tool declaration changes / 工具声明改动
四个
tools[].description及 zh-CN、en、ja、ko 文案已同步受管 URI 展示、复用、附件交接和按需路径解析契约;parameters 未修改。顶层whenToUse使未显式选择其他媒体渠道的生图、改图和视频请求优先召回 Art,运行时 result note 保持同一处理语义。Verification / 验证
本地 macOS Desktop 0.1.68 E2E:真实
.cindy包安装通过;普通“生成一张夏天的图”命中 Art → Cindy Core media,没有调用 harness 自带 image tool;结果只展示一次;显式询问路径时调用resolve_local_path;后续改图直接复用原始cindy-media://地址。Sensitive changes / 敏感变更
仅将
minCindyVersion从 0.1.56 提高到 0.1.68,并已完成精确版本安装验证。未改依赖、vendor、二进制资源、OAuth/API scope、凭证或鉴权边界、network/secret/slot/tool/Node capability、provisioning audience 或其它发布策略。