Repository navigation
Drop redundant GBS test tasks, tighten Kover, and add Codecov config - #52
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #52 +/- ##
=============================================
+ Coverage 25.39% 25.85% +0.46%
- Complexity 4918 5042 +124
=============================================
Files 610 610
Lines 73053 73056 +3
Branches 12590 12591 +1
=============================================
+ Hits 18550 18892 +342
+ Misses 52626 52274 -352
- Partials 1877 1890 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zrm22
approved these changes
Oct 22, 2026
pjbradbury
approved these changes
Oct 22, 2026
aberthel
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up how tests and code coverage run in CI.
Since PR #16, all GBS v2 tests generate their own data with
GBSSimDataand run inside the maintesttask. None of them read-Dgbs.test.dataset, sogbsTest,gbsTestSmall, andgbsTestLargewere just re-running the same tests under different names. And because Kover instruments everyTesttask by default, the coverage job was running those three tasks plusstatisticsTeston top oftest.This PR removes the three redundant GBS tasks, tells Kover to skip
statisticsTest(which already runs in its own required CI job), and raises the Kover branch coverage minimum from 18% to 23% to sit one point below the measured 24.46%. It also adds acodecov.ymlconfig with patch targets and per-area components.Note:
developstill needs to be done in the Codecov repository settings UI.dataFiles/GBS/README.txtnoted in GBS v2 real-data validation: restore it, or remove the redundant gbsTest* tasks #25 lives in thetassel_test_dataarchive repo, not here.Closes #25, closes #33, closes #34.
gbsTest,gbsTestSmall, andgbsTestLargeGradle tasks (GBS v2 real-data validation: restore it, or remove the redundant gbsTest* tasks #25)testtask only, skippingstatisticsTest(Kover: measure coverage from the test task only, and ratchet the floor #34)codecov.ymlwith project and patch status targets and component breakdowns (Configure Codecov: default branch, patch target, and per-area components #33)GBSConstantsto match (GBS v2 real-data validation: restore it, or remove the redundant gbsTest* tasks #25, Kover: measure coverage from the test task only, and ratchet the floor #34)Type of change
What type of changes does your code introduce? Put an
xin boxes that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Checklist:
develop(use the hotfix template if this targetsmain)versionvariable inbuild.gradle.kts