Repository navigation
Statistics gate: re-enable 4 of the 8 skipped tests (#38) - #47
Merged
btmonier merged 4 commits intoOct 22, 2026
Conversation
These tests compared results to within 8e-10, which is finer than the stored float values can hold. CI on x64 Linux got values that differ in the last digit or two, so the tests failed there but passed on macOS. Use 8e-6, the same tolerance as DominanceCenteredIBSTest.
This matrix has diagonal values up to about 30, so float rounding differences are larger than in the other IBS tests. CI got a difference of about 1.1e-5 on a value near 25. Use 1e-4 for this test.
…stics-gate-skipped-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #47 +/- ##
=============================================
+ Coverage 25.09% 25.38% +0.28%
- Complexity 4872 4918 +46
=============================================
Files 610 610
Lines 73053 73053
Branches 12590 12590
=============================================
+ Hits 18336 18546 +210
+ Misses 52842 52628 -214
- Partials 1875 1879 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
btmonier
self-requested a review
October 22, 2026 17:03
btmonier
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #38 (Tracking: #46)
Why this change was needed
The required
statisticsTestCI gate runs 59 tests across 26 classes, of which 8 were previously annotated with bare@Ignoreannotations:CenteredIBSTest.testCenteredIBSTest,NormalizedIBSTest.testNormalizedIBSTest,DominanceNormalizedIBSTest.testDominanceNormalizedIBSTest, andPrinCompTest.test) pass ondevelop, except thatPrinCompTest(andSolveByOrtholgonalizingTest) would fail ifDoubleMatrixTest.testBlasran earlier and left the globalDoubleMatrixFactory.DEFAULTset toFactoryType.blas.DoubleMatrixTestmutatedDoubleMatrixFactory.DEFAULTviaDoubleMatrixFactory.setDefault(...)in each test without restoring the previous factory type afterward.DoubleMatrixTest.testBlaswas unconditionally@Ignored instead of checking at runtime whether the optional nativeTasselBlasJNI library (Retire or test: the native BLAS path (TasselBlas JNI) #45) is available.MLMTest.testCompressionP3D,AdditiveSiteTest.testGenotypeAdditiveSite, andStepwiseAdditiveModelFitterTest.test) had bare@Ignoreannotations with no reason or issue link (Require a reason and an issue link on every @Ignore #35).What changed
@Ignore(and unusedorg.junit.Ignoreimports) fromCenteredIBSTest,NormalizedIBSTest,DominanceNormalizedIBSTest, andPrinCompTest.DoubleMatrixFactory.DEFAULTstate inDoubleMatrixTest: Added@Before saveFactory()and@After restoreFactory()hooks to saveDoubleMatrixFactory.DEFAULT.getType()before each test and restore it viaDoubleMatrixFactory.setDefault(savedType)afterward.DoubleMatrixTest.testBlasto a runtime assumption: Replaced@IgnorewithAssume.assumeTrue(canLoadTasselBlas())aroundSystem.loadLibrary("TasselBlas")so the test self-skips whenTasselBlasis absent and runs when present (Retire or test: the native BLAS path (TasselBlas JNI) #45).@Ignoreannotations (Require a reason and an issue link on every @Ignore #35): Added issue links and reasons toMLMTest.testCompressionP3D(MLMTest.testCompressionP3D: compression table has 125 rows, expected 131 #39),AdditiveSiteTest.testGenotypeAdditiveSite(Stepwise model fitter tests fail: AdditiveSiteTest and StepwiseAdditiveModelFitterTest #40), andStepwiseAdditiveModelFitterTest.test(Stepwise model fitter tests fail: AdditiveSiteTest and StepwiseAdditiveModelFitterTest #40).Effects & Verification
./gradlew statisticsTestnow runs all 59 tests with 55 passing, 0 failures, and 4 skipped (DoubleMatrixTest.testBlasviaAssumeplus the 3@Ignored tests tracked in MLMTest.testCompressionP3D: compression table has 125 rows, expected 131 #39 and Stepwise model fitter tests fail: AdditiveSiteTest and StepwiseAdditiveModelFitterTest #40).DoubleMatrixTestno longer leaksDoubleMatrixFactory.DEFAULTmutations to subsequent tests (PrinCompTestandSolveByOrtholgonalizingTestpass reliably when run afterDoubleMatrixTest).@Ignoreannotations remain in thestatisticsTestgate.CenteredIBSTest,NormalizedIBSTest,DominanceNormalizedIBSTest, andPrinCompTestin thestatisticsTestgate (Statistics gate: re-enable 4 of the 8 skipped tests #38)DoubleMatrixFactory.DEFAULTaround each test inDoubleMatrixTestand guardtestBlaswithAssume.assumeTrueonTasselBlasavailability (Statistics gate: re-enable 4 of the 8 skipped tests #38, Retire or test: the native BLAS path (TasselBlas JNI) #45)@Ignoreannotations inMLMTest,AdditiveSiteTest, andStepwiseAdditiveModelFitterTest(Require a reason and an issue link on every @Ignore #35, MLMTest.testCompressionP3D: compression table has 125 rows, expected 131 #39, Stepwise model fitter tests fail: AdditiveSiteTest and StepwiseAdditiveModelFitterTest #40)Type of change
What type of changes does your code introduce? Put an
xin boxes that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Checklist:
develop(use the hotfix template if this targetsmain)versionvariable inbuild.gradle.kts