Skip to content

Statistics gate: re-enable 4 of the 8 skipped tests (#38) - #47

Merged
btmonier merged 4 commits into
maize-genetics:developfrom
PUSHPAK-JAISWAL:fix/issue-38-statistics-gate-skipped-tests
Oct 22, 2026
Merged

btmonier merged 4 commits into
maize-genetics:developfrom
PUSHPAK-JAISWAL:fix/issue-38-statistics-gate-skipped-tests

Conversation

@PUSHPAK-JAISWAL

Copy link
Copy Markdown
Contributor

Description

Closes #38 (Tracking: #46)

Why this change was needed

The required statisticsTest CI gate runs 59 tests across 26 classes, of which 8 were previously annotated with bare @Ignore annotations:

  1. Four of those tests (CenteredIBSTest.testCenteredIBSTest, NormalizedIBSTest.testNormalizedIBSTest, DominanceNormalizedIBSTest.testDominanceNormalizedIBSTest, and PrinCompTest.test) pass on develop, except that PrinCompTest (and SolveByOrtholgonalizingTest) would fail if DoubleMatrixTest.testBlas ran earlier and left the global DoubleMatrixFactory.DEFAULT set to FactoryType.blas.
  2. DoubleMatrixTest mutated DoubleMatrixFactory.DEFAULT via DoubleMatrixFactory.setDefault(...) in each test without restoring the previous factory type afterward.
  3. DoubleMatrixTest.testBlas was unconditionally @Ignored instead of checking at runtime whether the optional native TasselBlas JNI library (Retire or test: the native BLAS path (TasselBlas JNI) #45) is available.
  4. The remaining three failing tests (MLMTest.testCompressionP3D, AdditiveSiteTest.testGenotypeAdditiveSite, and StepwiseAdditiveModelFitterTest.test) had bare @Ignore annotations with no reason or issue link (Require a reason and an issue link on every @Ignore #35).

What changed

Effects & Verification

Type of change

What type of changes does your code introduce? Put an x in boxes that apply.

  • CHANGE (fix or feature that would cause existing functionality to not work as expected)
  • FEATURE (non-breaking change which adds functionality)
  • BUGFIX (non-breaking change which fixes an issue)
  • ENHANCEMENT (non-breaking change which improves existing functionality)
  • NONE (if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)

Checklist:

  • The base branch of this PR is develop (use the hotfix template if this targets main)
  • I have updated the version variable in build.gradle.kts
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated relevant documentation

PUSHPAK-JAISWAL and others added 4 commits October 13, 2026 11:50
These tests compared results to within 8e-10, which is finer than the stored float values can hold. CI on x64 Linux got values that differ in the last digit or two, so the tests failed there but passed on macOS. Use 8e-6, the same tolerance as DominanceCenteredIBSTest.
This matrix has diagonal values up to about 30, so float rounding differences are larger than in the other IBS tests. CI got a difference of about 1.1e-5 on a value near 25. Use 1e-4 for this test.
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 25.38%. Comparing base (b5d5066) to head (b239c98).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop      #47      +/-   ##
=============================================
+ Coverage      25.09%   25.38%   +0.28%     
- Complexity      4872     4918      +46     
=============================================
  Files            610      610              
  Lines          73053    73053              
  Branches       12590    12590              
=============================================
+ Hits           18336    18546     +210     
+ Misses         52842    52628     -214     
- Partials        1875     1879       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@btmonier
btmonier self-requested a review October 22, 2026 17:03
@btmonier
btmonier merged commit 2b1f8cb into maize-genetics:develop Oct 22, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Statistics gate: re-enable 4 of the 8 skipped tests

3 participants