MT-22678: Add search filter to contact lists get_list#73
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughContact list retrieval now accepts an optional ChangesContact list search
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Caller
participant ContactListsApi
participant HTTPClient
Caller->>ContactListsApi: get_list(search)
ContactListsApi->>HTTPClient: Send search query parameter
HTTPClient-->>ContactListsApi: Return filtered contact lists
ContactListsApi-->>Caller: Return ContactList objects
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
https://railsware.atlassian.net/browse/MT-22678
Changes
searchargument tocontact_lists.get_list— filters contact lists by name (case-insensitive prefix match), per the OpenAPIGET /api/contacts/listsparam. Sent only when provided, so the default call is unchanged.How to test
client.contact_lists.get_list()— returns all contact lists (unchanged behaviour).client.contact_lists.get_list(search="news")— returns only lists whose name starts with "news" (case-insensitive).Summary by CodeRabbit
New Features
Documentation
Tests