MT-22678: Add search param to contact lists getList#142
Open
Rabsztok wants to merge 2 commits into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughAdds optional case-insensitive prefix search by name to contact list retrieval, with API type support, request handling, tests, and updated usage documentation. ChangesContact list search
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Example
participant ContactListsApi
participant ContactListsEndpoint
Example->>ContactListsApi: getList({ search: "news" })
ContactListsApi->>ContactListsEndpoint: GET contact lists with search parameter
ContactListsEndpoint-->>ContactListsApi: Return filtered contact lists
ContactListsApi-->>Example: Provide filtered results
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
IgorDobryn
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
https://railsware.atlassian.net/browse/MT-22678
Changes
{ search }option tocontactLists.getList— filters contact lists by name (case-insensitive prefix match), per the OpenAPIGET /api/contacts/listsparam. Sent only when provided, so the no-arg call is unchanged.How to test
client.contactLists.getList()— returns all contact lists (unchanged behaviour).client.contactLists.getList({ search: "news" })— returns only lists whose name starts with "news" (case-insensitive).Summary by CodeRabbit