Skip to content

MT-22678: Add search query param to contact lists findAll#56

Open
Rabsztok wants to merge 2 commits into
mainfrom
MT-22678-java-contact-list-search
Open

MT-22678: Add search query param to contact lists findAll#56
Rabsztok wants to merge 2 commits into
mainfrom
MT-22678-java-contact-list-search

Conversation

@Rabsztok

Copy link
Copy Markdown
Contributor

Motivation

https://railsware.atlassian.net/browse/MT-22678

Changes

  • Add a ListContactListsQueryParams with an optional search field and a findAll(accountId, params) overload — filters contact lists by name (case-insensitive prefix match), per the OpenAPI GET /api/contacts/lists param. The existing findAll(accountId) is kept, so the change is backward compatible.

How to test

  • contactLists().findAll(accountId) — returns all contact lists (unchanged behaviour).
  • contactLists().findAll(accountId, params) with search="news" — returns only lists whose name starts with "news" (case-insensitive).

@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Rabsztok, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5963ecf4-66dc-47a3-93cf-876dffe804b3

📥 Commits

Reviewing files that changed from the base of the PR and between 1b209fb and f221b50.

📒 Files selected for processing (7)
  • examples/java/io/mailtrap/examples/contactlists/ContactListsExample.java
  • src/main/java/io/mailtrap/api/contactlists/ContactLists.java
  • src/main/java/io/mailtrap/api/contactlists/ContactListsImpl.java
  • src/main/java/io/mailtrap/model/request/contactlists/ListContactListsQueryParams.java
  • src/test/java/io/mailtrap/api/contactlists/ContactListsImplTest.java
  • src/test/resources/api/contact_lists/contactListsWithSearchEmptyResponse.json
  • src/test/resources/api/contact_lists/contactListsWithSearchSingleResponse.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread README.md Outdated

- [Contacts](examples/java/io/mailtrap/examples/contacts/ContactsExample.java)
- [Contact Lists](examples/java/io/mailtrap/examples/contactlists/ContactListsExample.java)
- [Contact Lists](examples/java/io/mailtrap/examples/contactlists/ContactListsExample.java) (incl. filtering lists by name via the `search` query param — case-insensitive prefix match)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need such detail. Contact export for example has filters too but we don't elaborate on it here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Simplified it in remaining SDK Prs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants