fix(core): avoid char-boundary panic in decode_entities - #54
Merged
Merged
Conversation
The entity terminator search sliced the string at a fixed 12-byte offset, which panics when a multi-byte character straddles it (e.g. "& Kuchen, Säfte"). Search the bytes for `;` instead. Fixes mahype#53 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Problem
decode_entitiesschnitt den String für die Suche nach dem;an einer festen Byte-Position (12) ab. Liegt dort ein Mehrbyte-Zeichen wieä, paniciert Rust – beim Neuaufbau des Such-Caches crasht TorroMail.Fix
Das
;wird jetzt byteweise im 12-Byte-Fenster gesucht. Da;ASCII ist, ist der gefundene Index immer eine gültige Zeichengrenze.Test
an_ampersand_before_multibyte_text_does_not_panic. Er schlägt mit dem alten Code fehl und läuft mit dem Fix durch.cargo test -p torromail-core mime: alle Tests grün.🤖 Generated with Claude Code