Repository navigation
document Polymarket Safe tx signing on /wallet/sign and eth_sign typedData - #142
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
josh-payward
approved these changes
Nov 12, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to Reviewers
This goes with WAL-372 in uoa-server and fridge. The UOA page should merge when uoa-server deploys and the Express API pages when fridge deploys; if they ship together, merge this after both.
Polymarket's relayer only accepts Safe signatures as eth_sign over the 32-byte SafeTx hash, so partners can't use typed-data signing for Safe transactions.
/wallet/signnow accepts{method: eth_sign, data: <SafeTx hash>, safeTxTypedData}and checks the SafeTx before signing. Underneath, fridge'ssign/dataacceptseth_signwith an optionaltypedData, bindsdatato it, and screens it.This branch starts from the #141 branch, so its commits appear here already merged.
Changes Made
uoa/api-reference/wallet-operations.mdx: the request shape, the four checks (canonical SafeTx; chain 137 and the user's own Safe; delegatecall only to MultiSend with plain inner calls; no calls to the Safe itself), and how to pack the signature for the relayer (avof 31 or 32)transaction_data,raw_data_hashand warning text to cover both typed data and Safe transactionseth_signrow of thesign/datamethod table inserver-wallets/express-api/wallet-operations.mdxto describe the optionaltypedDataeth_signmethod andtypedDatafield entries inserver-wallets/express-api/policy/transaction-data.mdxTesting: How do you know it works?
Manual Testing Guide
typedDatarule matches fridge's tests.vpacking rule matches the relayer SDK'ssplit_and_pack_sig: add 4 to 27/28, or 31 to 0/1.