Skip to content

Document login origin in custom email templates - #138

Merged
josh-payward merged 1 commit into
mainfrom
codex/custom-email-login-origin
Nov 3, 2026
Merged

josh-payward merged 1 commit into
mainfrom
codex/custom-email-login-origin

Conversation

@josh-payward

@josh-payward josh-payward commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Document login.origin for custom OTP and email-link templates, including the domain-allowlist requirement, cases where it is empty, and conditional usage. Test-send documentation now identifies the https://example.com sample origin.

Validation: reviewed the MDX diff and ran git diff --check. This documentation repository has no local test/build script.

Hold publication until the companion toaster implementation is deployed to production. Related: https://seabound.atlassian.net/browse/WAL-103.

Companion draft PRs: https://github.com/magiclabs/toaster/pull/354, https://github.com/magiclabs/dashboard-api/pull/421, and https://github.com/magiclabs/magic-dashboard/pull/1873.

Manual sandbox verification — 2026-10-27

The documented behavior was checked against received emails from sandbox:

  • The dashboard's test-email action rendered the documented sample origin, https://example.com.
  • A real Email OTP login selected the saved template with the documented overrides.variation option and rendered the allowlisted origin http://localhost:3013.
  • With a temporary wildcard allowlist entry, requests containing a space, backslash, or non-breaking space in the referrer hostname each delivered an OTP email with Origin omitted, using the documented {% if login.origin %} conditional.

Josh performed the manual sends and shared the resulting emails. Exact malformed inputs and results are recorded in https://github.com/magiclabs/toaster/pull/354. This validates the documented sample, successful origin display, and conditional handling of rejected origins for Email OTP. Live email-link login was not manually exercised; its renderer is covered by the companion toaster tests.

The production-publication hold above still applies; these results are from sandbox.

@mintlify

mintlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
magic-labs 🟢 Ready View Preview Oct 26, 2026, 10:30 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@josh-payward
josh-payward merged commit 2505eab into main Nov 3, 2026
8 checks passed
@josh-payward
josh-payward deleted the codex/custom-email-login-origin branch November 3, 2026 00:28

This branch was successfully deployed

1 active deployment
staging — 341db9d2 Deployed Oct 26, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants