Repository navigation
Document login origin in custom email templates - #138
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
josh-payward
marked this pull request as ready for review
October 30, 2026 17:28
jerry-payward
approved these changes
Nov 3, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document
login.originfor custom OTP and email-link templates, including the domain-allowlist requirement, cases where it is empty, and conditional usage. Test-send documentation now identifies thehttps://example.comsample origin.Validation: reviewed the MDX diff and ran
git diff --check. This documentation repository has no local test/build script.Hold publication until the companion toaster implementation is deployed to production. Related: https://seabound.atlassian.net/browse/WAL-103.
Companion draft PRs: https://github.com/magiclabs/toaster/pull/354, https://github.com/magiclabs/dashboard-api/pull/421, and https://github.com/magiclabs/magic-dashboard/pull/1873.
Manual sandbox verification — 2026-10-27
The documented behavior was checked against received emails from sandbox:
https://example.com.overrides.variationoption and rendered the allowlisted originhttp://localhost:3013.{% if login.origin %}conditional.Josh performed the manual sends and shared the resulting emails. Exact malformed inputs and results are recorded in https://github.com/magiclabs/toaster/pull/354. This validates the documented sample, successful origin display, and conditional handling of rejected origins for Email OTP. Live email-link login was not manually exercised; its renderer is covered by the companion toaster tests.
The production-publication hold above still applies; these results are from sandbox.