Repository navigation
document sign/data as ETH-only and point Solana to sign message - #137
Merged
Merged
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
pws-kj
approved these changes
Oct 26, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to WAL-165. Fridge now rejects unbound
sign/datahashes on every chain, not just ETH (fridge PR #___). Only ETH has atransaction_dataformat to check the hash against, sosign/datais effectively ETH-only. The reference listedETH,SOLandBTC, which was already inaccurate: the v2 route never supported Solana or Bitcoin.Merge with or before the fridge change.
Changes
express-api/wallet-operations.mdx, Sign Data →X-Magic-Chain: onlyETHis supported; other chains' requests are rejected. Points Solana callers to Sign Message with the serialized transaction message, which the KMS now screens (tee-kms PR #___).Testing
mint broken-links: no new broken links (the 18 existing ones are in unrelated embedded-wallet pages).Not changed
sign/transactionyet.