Skip to content

document sign/data as ETH-only and point Solana to sign message - #137

Merged
oxyn-payward merged 1 commit into
mainfrom
WAL-165-sign-data-eth-only
Oct 26, 2026
Merged

oxyn-payward merged 1 commit into
mainfrom
WAL-165-sign-data-eth-only

Conversation

@oxyn-payward

Copy link
Copy Markdown
Contributor

Summary

Follow-up to WAL-165. Fridge now rejects unbound sign/data hashes on every chain, not just ETH (fridge PR #___). Only ETH has a transaction_data format to check the hash against, so sign/data is effectively ETH-only. The reference listed ETH, SOL and BTC, which was already inaccurate: the v2 route never supported Solana or Bitcoin.

Merge with or before the fridge change.

Changes

  • express-api/wallet-operations.mdx, Sign Data → X-Magic-Chain: only ETH is supported; other chains' requests are rejected. Points Solana callers to Sign Message with the serialized transaction message, which the KMS now screens (tee-kms PR #___).

Testing

  • mint broken-links: no new broken links (the 18 existing ones are in unrelated embedded-wallet pages).

Not changed

  • No Bitcoin pointer: no Express page documents sign/transaction yet.

@oxyn-payward oxyn-payward self-assigned this Oct 26, 2026
@mintlify

mintlify Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
magic-labs 🟢 Ready View Preview Oct 26, 2026, 11:23 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@oxyn-payward
oxyn-payward merged commit 3a8c148 into main Oct 26, 2026
8 checks passed
@oxyn-payward
oxyn-payward deleted the WAL-165-sign-data-eth-only branch October 26, 2026 18:33

This branch was successfully deployed

1 active deployment
staging — 1a0528b9 Deployed Oct 26, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants