Repository navigation
Conversation
Marking a file reviewed now jumps the selection to the next file that still needs eyes (wrapping past the end, skipping the All row and already-reviewed files), so a full review pass is r-r-r instead of r-j-r-j; when nothing is left it flashes 'all changes reviewed' and stays. Un-marking stays put — going back to a file to unmark it is deliberate. The unreviewed-only view keeps its existing behavior (the marked file drops out, which advances by itself). Also de-ambiguates the filter's labels: the footer hint read 'U unreviewed', which parses as un-review; it now reads 'hide reviewed', and the active-filter title says 'unreviewed only'.
Marking a file in the unreviewed-only view re-filters the list via SetItems, which reset the selection to the top — advancing only for a top-to-bottom pass and yanking the reviewer back to row one when they marked from the middle. Re-select the next unreviewed file after the marked one instead (the same nextUnreviewed target the default view's auto-advance uses), falling back to the top only when the list empties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review-flow polish for the reviewed marks in
rift diff:rauto-advances: marking a file jumps to the next unreviewed one (wrapping, skipping the All row and ticked files), so a full pass isrrr. When nothing is left it flashes "all changes reviewed" and stays put.rstays a toggle: pressing it on a reviewed file unmarks and does not advance — revisiting is deliberate.Ulabeling: the footer hint readU unreviewed, which parses as "un-review"; it now readsU hide reviewed, and the active filter showsunreviewed onlyin the list title. (Ufilters the view; it never changes marks.)The unreviewed-only view keeps its existing self-advancing behavior (marked files drop out of the list). New
SplitList.SelectKeypowers the programmatic advance;nextUnreviewedis unit-tested (advance, skip, wrap, exhausted).Verification
mise run checkgreen.rmarks and advances (✓ glyph, counter increments, selection moves), marking the last file flashes "all changes reviewed" without moving,ron a reviewed file unmarks and stays.🤖 Generated with Claude Code
https://claude.ai/code/session_01EB5anNK6czSCdjg51CH7VD