Skip to content

Forward Range header to ServeFile when streaming episodes #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
honzup wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Forward Range header to ServeFile when streaming episodes #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions rust-api/src/handlers/podcasts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3265,6 +3265,7 @@ pub async fn stream_episode(
State(state): State<crate::AppState>,
Path(episode_id): Path<i32>,
Query(query): Query<StreamQuery>,
headers: HeaderMap,
) -> Result<axum::response::Response, AppError> {
let api_key = &query.api_key;
info!("Stream request for episode {} with api_key {} and user_id {}", episode_id, api_key, query.user_id);
Expand Down Expand Up @@ -3355,9 +3356,23 @@ pub async fn stream_episode(
use tower::ServiceExt;

let service = ServeFile::new(&path);
let request = axum::http::Request::builder()
.method("GET")
.uri("/")
// Forward the range/conditional headers ServeFile needs so it can answer with
// 206 Partial Content. Without them it always returns the full file with 200, and
// iOS AVPlayer re-fetches from byte 0 on every buffer refill (the "stream keeps
// restarting" loop). Only these headers are copied — auth stays in the query string.
let mut builder = axum::http::Request::builder().method("GET").uri("/");
for name in [
axum::http::header::RANGE,
axum::http::header::IF_RANGE,
axum::http::header::IF_MODIFIED_SINCE,
axum::http::header::IF_NONE_MATCH,
axum::http::header::IF_UNMODIFIED_SINCE,
] {
if let Some(value) = headers.get(&name) {
builder = builder.header(name, value);
}
}
let request = builder
.body(axum::body::Body::empty())
.map_err(|e| AppError::external_error(&format!("Failed to build request: {}", e)))?;

Expand Down
Loading