Repository navigation
Conversation
ashtonian
marked this pull request as ready for review
October 18, 2026 02:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time the API supplies an episode's playback settings, it makes two sequential database trips: one for the listener's default speed and another for that podcast's settings. This adds avoidable database work to starting playback.
Fetch both together, removing one database trip per request while preserving the chosen speed and intro/outro skip settings. For example, a podcast set to 1.5x still uses 1.5x, and a podcast without its own setting still uses the listener's default. There is no measured end-to-end playback speedup yet.
Validation: all 21 Rust API tests pass when combined with #1010, against PostgreSQL 18 with MariaDB 11.4 and again with MySQL 8.4. Coverage includes default/customized/missing settings and separation between users. Adds CI coverage with disposable databases; GitHub Actions await maintainer approval. No schema migration or runtime dependency is added.
Can land independently of the pagination and streaming PRs.