Skip to content

fix(desktop): let every CEF first responder own the paste hotkey #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
banozz0 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(desktop): let every CEF first responder own the paste hotkey #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions apps/desktop/src/app/focus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,12 +402,21 @@ impl GhostexGpuiApp {
&self,
cx: &mut gpui::Context<Self>,
) -> bool {
/*
CDXC:GPUICefFirstResponderPastePassthrough 2026-08-27:
Every CEF surface qualifies, not just the editable Source/Manage/Chat
renderers: `shell_focus` keeps naming a terminal pane while a modal,
the sidebar, a Kanban page, a titlebar popup, or a browser tab holds
AppKit's first responder, so without this gate the Cmd+V binding
shadow-pastes the same clipboard into that pane's hidden terminal
composer. That phantom draft is what a later chat send's
draft-preservation step sweeps into Saved Prompts. A Chromium first
responder always owns its own paste.
*/
#[cfg(target_os = "macos")]
let renderer_edit_cef_owns_native_focus = matches!(
self.first_responder_target,
FirstResponderTarget::CefSurface(FirstResponderCefSurface::ProjectWorkarea(
ProjectWorkareaCefSurfaceSlotKey::Source | ProjectWorkareaCefSurfaceSlotKey::Manage
)) | FirstResponderTarget::CefSurface(FirstResponderCefSurface::SessionChat(_))
FirstResponderTarget::CefSurface(_)
);
#[cfg(not(target_os = "macos"))]
let renderer_edit_cef_owns_native_focus = false;
Expand Down