fix: Fixed null return from command suggester causing game crash - #6
Merged
Merged
Conversation
Modified line 16 in ClientCommands.java Ensured suggestMatching() does not receive null parameters Returns empty list instead of null
maDU59
approved these changes
Dec 4, 2025
maDU59
left a comment
maDU59
left a comment
Owner
There was a problem hiding this comment.
Seems good, I didn't know that was an issue, thanks!
Owner
|
This fix has been uploaded to Modrinth and you're credited in the release's notes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified line 16 in ClientCommands.java
Ensured suggestMatching() does not receive null parameters
Returns empty list instead of null