Repository navigation
Give the server tests more time than the default 5 seconds - #83
Merged
Merged
Conversation
Sign-ins hash the password with scrypt, so the sign-in tests take several seconds on a slow CI runner. One of them timed out in the CI run for the docker/login-action update although nothing it tests had changed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
CI for #81 failed in
packages/server/test/auth.test.ts("does not count a right password as a failed attempt") with "Test timed out in 5000ms". The test signs in nine times, and each sign-in hashes the password with scrypt on purpose, so on a slow runner it took about 9 seconds. That run took 6 minutes instead of the usual 1.5, and #81 only changes the release workflow, so the failure was a slow runner rather than the update.The new
packages/server/vitest.config.tsraises the test timeout for the server package to 30 seconds. Nothing changes for users.Checklist
pnpm lint,pnpm typecheckandpnpm testpass