Repository navigation
Turn forms with a head on one side round as a whole where they go - #142
Merged
Merged
Conversation
So far only the face turned when a pet went right, and a chameleon walked with its tail in front. Forms with a head on one side and a tail, shell or ball on the other (HEADING in the scene: 7 babies, 12 children, 19 adults) are now drawn mirrored when they face the other way, at home, on trips, in a scuffle, as a visitor and in the yard. Round forms and those with something held in one hand (tray, lance, plan) only turn their face, as before. Effects tied to a spot of the body follow the turned body: the part that moves by itself (a lion's head, a sun ball), the backpack and where food lands, the key's ticks, the yawn, the paper planes, the fireworks, the moss and the pompoms. Palettino and Axodrake no longer turn round by hand for their special move: facing the opponent, they already are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01329FGaZ2R2yreSBvZMdcz4
The contract test read the pet's answers on today's date, so the festival fields came and went with the poster and the test failed on main. Same change as in #141; it no-ops once that is merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01329FGaZ2R2yreSBvZMdcz4
Owner
Author
|
The Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Michael · project thread
What
Until now only the face turned when a pet went the other way, so a chameleon walked right with its tail in front. Forms whose head is on one side and whose tail, shell or ball is on the other are now drawn fully mirrored when they face the other way.
HEADINGincore/src/scene.tslists them: 7 babies, 12 children and 19 adults. This applies at home, on trips, in a scuffle, as a visitor and in the yard. Their light then comes from the top right.Round forms, and forms whose only asymmetry is something held in one hand (tray, lance, plan, teapot spout), only turn their face, as before. Their "the body isn't drawn mirrored" effects stay as they are.
Effects checked form by form
reach()knows the facing, which fixes the backpack position, where thrown food lands and the fishing spot.art()/column()helper: Cogsqueak's key ticks, Snorbear's yawn, Origrane's paper planes, Lionkite's fireworks and pompoms, Mossolotl's moss, Mirrorleon's prism and Solroll's ball vault.turn) for their special move. That turn is removed, because facing the opponent they are already turned.Tests
npm run checkpasses.npm test: 456 pass, 1 fail. The one failure isapi.test.ts(festival fields in the contract), and it fails the same way onmainwithout this change.docs/images/petsanddocs/pet_preview.pngare unchanged: icons are drawn without a facing, and blob and Angloop are not in the list.Generated by Claude Code