Fix z_l->lev rename for OM4 snapshot sources#756
Draft
alxmrs wants to merge 1 commit into
Draft
Conversation
The 5-daily snapshot source (1958-2022.OM4p25_5daily_snapshots) exposes the depth-center coordinate as z_l but has no z_i. The old rename gated the z_l->lev rename on z_i being present, so z_l was left intact and downstream rechunking on "lev" failed with a ValueError (issue #450). Extract normalize_vertical_coords() to rename z_l->lev and z_i->ilev independently, and key the interface-info branch on ilev rather than z_i. Behavior is unchanged for the averaged sources (which carry z_i). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
I ran this script on with the small data setting and wrote the results to my machine. Here is the dataset it produced: Here is the command I used: |
Member
Author
|
@codex may I have your review? |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 5-daily snapshot source (1958-2022.OM4p25_5daily_snapshots) exposes the depth-center coordinate as z_l but has no z_i. The old rename gated the z_l->lev rename on z_i being present, so z_l was left intact and downstream rechunking on "lev" failed with a ValueError (issue #450).
Extract normalize_vertical_coords() to rename z_l->lev and z_i->ilev independently, and key the interface-info branch on ilev rather than z_i. Behavior is unchanged for the averaged sources (which carry z_i).
🤖