Repository navigation
fix(vm): stop warning once per entity on BETWEEN with an unsupported left-hand type - #61
Merged
Merged
Conversation
…left-hand type walkTernary logged "between not implemented for type ..." every time it evaluated BETWEEN against a map, slice or string value. Filters are evaluated per entity, so one audience using BETWEEN on a whole map[string]time field flooded lio's metaforarunner logs. The result is unchanged: (nil, false), i.e. no match, the same silent outcome evalBinary already gives a map compared with < or >. Checks run: - go test ./... : all packages pass - new vm cases (map BETWEEN, map NOT BETWEEN, slice BETWEEN) pass before and after; they pin the no-match result, not the log line - go test -v ./vm/ -args -vv : "between not implemented" printed 3 times before the change, 0 after Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
janveltm
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
lio's metaforarunner is logging this warning in large volumes:
The warning comes from
walkTernarywheneverBETWEEN's left-hand value is a type the VM can't range-compare (a map, slice or string). Filters are evaluated once per entity, so a single audience withsome_map_field BETWEEN "a" AND "b"logs one line for every profile it scans.This PR removes the log line. The evaluation result doesn't change.
(nil, false)+ a warning per evaluation(nil, false), nothing loggedThis matches
evalBinary, which already returns(nil, false)silently for a map compared with<or>.Why the filters exist
lio's audience builder (lytics-ui) could save
BETWEENon a wholemap[string]timefield when no key was picked. That path was fixed in lytics-ui #5133 / #5147. A separate lio change will reject the shape when an audience is saved, and audiences already saved with it still need cleaning up. This PR only removes the log noise.Checks run
go test ./...: all packages pass.vmcases (mt BETWEEN …,mt NOT BETWEEN …,urls BETWEEN …) pass both before and after the change. They pin the no-match result so membership can't shift. They don't pin the absence of the log line.go test -v ./vm/ -args -vv:between not implementedis printed 3 times before the change and 0 after.vm/vm_test.go'smsgContextmap literal is already not gofmt-clean onmaster. I left it alone to keep the diff small.Follow-up in lio
Bump
github.com/lytics/qlbridgeonce this merges.🤖 Generated with Claude Code