Recover late Xcode bridge pool attachment#185
Conversation
Serialize secondary mcpbridge attachment behind the route catalog, require an exact pinned tools/list verification before exposing a slot, and retry failed attachment with injected 1s/10s scheduling.
Make test and verifier teardown structurally await client shutdown so terminal cleanup cannot leak into later work. Add a gate-driven regression for unsupported-handshake cleanup without relying on wall time.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 355f5b0049
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Start serialized sibling recovery before a route has a catalog, while keeping recovered slots non-routable until their exact attach probe succeeds. This lets a verified sibling establish the first catalog when the primary catalog load fails.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13aba31fae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Inject the runtime timeout scheduler into router-owned probe registrations so response receipt wins over delayed future delivery. Drive timeout races by recorded schedulers instead of wall-clock waits.
Keep recovery initialize participants uncommitted until the exact attachment probe succeeds. Commit health, process recovery, and canonical publication under one rollback-safe transaction, and settle rejected probe waiters at the response-router boundary.
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Purpose
Ensure a late-started Xcode process receives the configured number of mcpbridge attachments instead of leaving secondary bridges unrecognized in Xcode.
Changes
tools/listattachment probe succeeds.JSONRPCResponseRouter, remove request mappings at the winning terminal boundary, and settle waiter-registration rejection during shutdown.Testing
scripts/check.sh(967 main, 24 process, and 13 stdio tests)RuntimeCoordinatorProcessRoutingTests,RuntimeCoordinatorRecoveryTests,ControlPlaneAuthorityTests, andJSONRPCResponseRouterTestscodex-reviewagainst pinned livemain8bd74384bbfe050094b80e99ce77415dff6dae98(0 findings)