Stabilize asynchronous runtime tests - #183
Merged
Merged
Conversation
Wait for the injected TestClock to register the foreground waiter deadline before advancing virtual time, so scheduler latency cannot race the inner shared-load timeout.
Wait for observable lease, initialization, catalog, and reconcile events instead of relying on executor scheduling. Keep genuinely blocking synchronous callbacks off the cooperative executor so low-capacity CI runners cannot deadlock the tests.
Keep slot activation synchronized by its recorded event while adding a watchdog that fails scheduling regressions instead of hanging serialized test suites.
Bound diagnostic waits, exercise reconcile triggers from an external executor, and assert retry ownership through atomic control-plane state while keeping event ordering independent of runner speed.
lynnswap
changed the title
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix CI failures caused by test ordering races and cooperative-executor blocking without using runner speed or wall-clock delays to drive test state.
Changes
Testing
Related failures: