Prevent STDIO shutdown file-handle race#182
Merged
Merged
Conversation
Wait for FileHandle.AsyncBytes iterator creation before closing its descriptor so an immediate stop cannot trigger NSFileHandleOperationException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prevent an immediate STDIO adapter shutdown from closing stdin before Foundation has prepared its async iterator. This race aborted the merged
mainCI run withNSFileHandleOperationException.Failing job: https://github.com/lynnswap/XcodeMCPKit/actions/runs/29392946378/job/87280397262
Changes
FileHandle.AsyncBytes.Iteratorcreation.Testing
remainingpackage-test command: 296 tests passed.scripts/check.sh: 951 standard, 24 process runtime, and 8 STDIO adapter tests passed.codex-review --base main: clean.