Handle unrecognized subscriptions with explicit policies - #7
Merged
Conversation
Add a dedicated delegate that can leave, finish, or project valid undeclared subscriptions in the catalog group. Reuse successful decisions by exact transaction revision and keep thrown decisions retryable. BREAKING CHANGE: StorePurchaseOutcome adds leftUnfinished, and AutoRenewableSubscriptionCatalogError no longer includes undeclaredProduct.
Expose registered synthetic unrecognized subscriptions through the scoped test harness and return semantic delivery outcomes. Prove delegate policy behavior through package tests and the external consumer fixture.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66ab673090
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
lynnswap
commented
Jul 23, 2026
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Allow an installed binary to handle valid auto-renewable subscriptions that were added to its App Store Connect group after the binary shipped, without conflating them with declared or out-of-group products.
Changes
UnrecognizedSubscriptionDelegateandUnrecognizedSubscriptionPolicywithleaveUnfinished,finish, andtreatAsdecisions.StorePurchaseOutcome.leftUnfinishedwhen the framework intentionally does not finish a delivery.TransactionStoreDelegateownership and reject true catalog metadata contradictions.StoreTransactionKitTestingfactories and delivery APIs for unrecognized subscriptions, including admission and replay-ordering coverage.Testing
swift test— 125 tests passedswift test --package-path Fixtures/ExternalConsumer— 2 tests passedxcodebuild docbuild -scheme StoreTransactionKit -destination 'generic/platform=macOS'— passedxcrun swift-format lint --recursive --strict Sources Tests Tools/TestApp Package.swift— passedgit diff --check— passedorigin/main— no findings