Skip to content

fix: clear calendar reminder timers on disable #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leandromqrs merged 1 commit into from
Sep 15, 2026
Merged

fix: clear calendar reminder timers on disable #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/panel/clock/calendarReminders/calendarReminders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ export class CalendarReminders extends Module {
private _pill: CalendarRemindersPill | null = null;
private _alerts: CalendarReminderController | null = null;
private _lifecycle: LifecycleScope | null = null;
private _refreshTimer: ManagedSource | null = null;
private _labelTimer: ManagedSource | null = null;
private _panelRevealTimer: ManagedSource | null = null;
private _startReminderTimer: ManagedSource | null = null;
private _notifiedStarts = new Map<string, number>();
Expand All @@ -57,6 +59,8 @@ export class CalendarReminders extends Module {
onStateChanged: () => this._render(),
});
this._lifecycle = lifecycle;
this._refreshTimer = refreshTimer;
this._labelTimer = labelTimer;
this._panelRevealTimer = panelRevealTimer;
this._startReminderTimer = createManagedSource(lifecycle);
this._pill = pill;
Expand Down Expand Up @@ -111,8 +115,15 @@ export class CalendarReminders extends Module {
}

override disable(): void {
if (this._refreshTimer) this._refreshTimer.clear();
if (this._labelTimer) this._labelTimer.clear();
if (this._panelRevealTimer) this._panelRevealTimer.clear();
if (this._startReminderTimer) this._startReminderTimer.clear();

this._lifecycle?.dispose();
this._lifecycle = null;
this._refreshTimer = null;
this._labelTimer = null;
this._panelRevealTimer = null;
this._startReminderTimer = null;
this._notifiedStarts.clear();
Expand Down