Repository navigation
feat(admin): hint when Nextcloud does not forward notifications by email - #300
Merged
Merged
Conversation
On a fresh instance the Notifications app keeps "Send email reminders about unhandled notifications" at "Never", so reminders and appointment notifications only reach the bell and the mobile app. The reminder settings now say so, link to the Notifications settings and can be collapsed, since some instances want it that way. The choice is stored for all admins. The admin and several appointment controllers lacked their psalm type imports, which hid findings and left baseline entries behind. With the imports in place: - Talk room, booking and check-in responses now go through the serializers and carry the fields their documented types promise (occupancy, isFull, waitlisted, effective booking status). - Vacation, audit and self-check-in payloads are typed at their source. - The navigation and response-list types no longer claim fields the server never sent. - The deprecated getAppValue and getJobs calls in the admin settings are replaced. Nothing is removed from any response, so older mobile clients keep working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
API changes (all additive, nothing removed)
occupancy,isFull,waitlistedand the effective booking status. The web client merges the talk room answer into its state, which now gets the resolvedallowMaybeinstead of the raw nullable value.seriesId/seriesPosition(never sent),isGuest/waitlistedon the response list are optional, team options are{id, label, type}.Test plan
./scripts/check.shpasses🤖 Generated with Claude Code