Skip to content

SP-3256: Add function to fetch dayobs-downtime summary - #205

Open
rhiannonlynne wants to merge 2 commits into
mainfrom
tickets/SP-3256
Open

SP-3256: Add function to fetch dayobs-downtime summary#205
rhiannonlynne wants to merge 2 commits into
mainfrom
tickets/SP-3256

Conversation

@rhiannonlynne

Copy link
Copy Markdown
Member

I'm not sure if this is what you had in mind or not.
I looked at just adding this in a notebook, but the information should go into one of the other HTML markup nicely formatted pieces you had in the output notebook, so that doesn't quite work.
This is about the best I could do for now, but I think you mentioned wanting to rationalize some of the rubin nights vs schedview fetching .. maybe this both indicates that that's a good idea but also illustrates an option?

@rhiannonlynne
rhiannonlynne requested a review from ehneilsen June 25, 2026 20:11
@ehneilsen

Copy link
Copy Markdown
Collaborator

Can you add a simple pytest or unittest? You can (probably should) make it get skipped by default do it doesn't get run by github CI (see what I do in tests/test_efd.py).

@rhiannonlynne

Copy link
Copy Markdown
Member Author

Test added, follows your key for the environment variable to flag whether or not to run the live unit test.

@rhiannonlynne

Copy link
Copy Markdown
Member Author

I think these unit tests are all failing for something other than what I changed -- and I think you might have a fix over on your PR branch?

@rhiannonlynne
rhiannonlynne force-pushed the tickets/SP-3256 branch 2 times, most recently from a91a8a7 to 27d8493 Compare July 1, 2026 09:58
@ehneilsen

Copy link
Copy Markdown
Collaborator

I think these unit tests are all failing for something other than what I changed -- and I think you might have a fix over on your PR branch?

It looks like the tests are failing because the new code depends on rubin_nights, which is not currently a schedview dependency, and so is not getting installed in the CI environment.

@rhiannonlynne

rhiannonlynne commented Aug 13, 2026 via email

Copy link
Copy Markdown
Member Author

@ehneilsen ehneilsen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

# Make some assumptions that ought to work in an RSP environment,
# or user's env variables match schedview's expectations,
# e.g. tokenfile set in env variable ACCESS_TOKEN_FILE.
site = schedview.clientsite.EFD_NAME.replace("_efd", "")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more direct way to do this would be schedview.clientsite.guess_site().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants