SP-3256: Add function to fetch dayobs-downtime summary - #205
SP-3256: Add function to fetch dayobs-downtime summary#205rhiannonlynne wants to merge 2 commits into
Conversation
|
Can you add a simple pytest or unittest? You can (probably should) make it get skipped by default do it doesn't get run by github CI (see what I do in tests/test_efd.py). |
|
Test added, follows your key for the environment variable to flag whether or not to run the live unit test. |
2efeb60 to
7f479dd
Compare
|
I think these unit tests are all failing for something other than what I changed -- and I think you might have a fix over on your PR branch? |
a91a8a7 to
27d8493
Compare
27d8493 to
ffc3a39
Compare
It looks like the tests are failing because the new code depends on rubin_nights, which is not currently a schedview dependency, and so is not getting installed in the CI environment. |
|
The old failures were something else .. I hadn’t looked at the new failures
since my update to the current main today.
Makes sense about Rubin nights though! Ok will go fix that next.
================================
Dr R. Lynne Jones
Research Scientist with Rubin Observatory
she/hers
================================
…On Thu, Aug 13, 2026 at 2:53 PM Eric H. Neilsen, Jr. < ***@***.***> wrote:
*ehneilsen* left a comment (lsst/schedview#205)
<#205 (comment)>
I think these unit tests are all failing for something other than what I
changed -- and I think you might have a fix over on your PR branch?
It looks like the tests are failing because the new code depends on
rubin_nights, which is not currently a schedview dependency, and so is not
getting installed in the CI environment.
—
Reply to this email directly, view it on GitHub
<#205?email_source=notifications&email_token=AAOFBXYVRFW3RW7DUUJJYX35JY2ERA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMRYGY4DEMRXGI3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5286822726>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOFBX6JLNADU6AACPAJ3XL5JY2ERAVCNFSNUABFKJSXA33TNF2G64TZHM2TENJUGU3TGMZTHNEXG43VMU5TINZUGIZTCMRVGY22C5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
| # Make some assumptions that ought to work in an RSP environment, | ||
| # or user's env variables match schedview's expectations, | ||
| # e.g. tokenfile set in env variable ACCESS_TOKEN_FILE. | ||
| site = schedview.clientsite.EFD_NAME.replace("_efd", "") |
There was a problem hiding this comment.
A more direct way to do this would be schedview.clientsite.guess_site().
I'm not sure if this is what you had in mind or not.
I looked at just adding this in a notebook, but the information should go into one of the other HTML markup nicely formatted pieces you had in the output notebook, so that doesn't quite work.
This is about the best I could do for now, but I think you mentioned wanting to rationalize some of the rubin nights vs schedview fetching .. maybe this both indicates that that's a good idea but also illustrates an option?