Skip to content

DM-56942: Add makeVisitDetectorTable to Daytime AP's pipeline #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsinfang merged 2 commits into from
Nov 5, 2026
Merged

DM-56942: Add makeVisitDetectorTable to Daytime AP's pipeline #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a7b24f
Correct makeVisitTable in bps clustering
hsinfang Nov 4, 2026
41aefbd
Add makeVisitDetectorTable task
hsinfang Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bps/clustering/clustering_Daytime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ cluster:
pipetasks: makeSampledImageSubtractionMetrics,analyzeSampledImageSubtractionMetrics
dimensions: visit,detector
consolidateVisit:
pipetasks: consolidateVisitSummary,makeVisitTable,consolidateDiaSourceTable,analyzeVisitSampledImageSubtractionMetrics,consolidatePromptSource,splitPromptSource
pipetasks: consolidateVisitSummary,consolidateDiaSourceTable,analyzeVisitSampledImageSubtractionMetrics,consolidatePromptSource,splitPromptSource
dimensions: visit


Expand Down
11 changes: 11 additions & 0 deletions pipelines/_ingredients/ApPipe.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,12 @@ tasks:
config:
connections.visitSummaries: visit_summary
connections.outputCatalog: visit_table
makeVisitDetectorTable:
class: lsst.pipe.tasks.postprocess.MakeCcdVisitTableTask
config:
connections.visitSummaryRefs: visit_summary
connections.outputCatalog: visit_detector_table
idGenerator.release_id: parameters.release_id
standardizePromptSource:
class: lsst.pipe.tasks.postprocess.TransformSourceTableTask
config:
Expand Down Expand Up @@ -273,6 +279,7 @@ subsets:
- analyzePreliminarySummaryStats
- consolidateVisitSummary
- makeVisitTable
- makeVisitDetectorTable
- consolidateDiaSourceTable
- analyzeVisitSampledImageSubtractionMetrics
- aggregateVisitSummary
Expand Down Expand Up @@ -316,6 +323,7 @@ subsets:
subset:
- consolidateVisitSummary
- makeVisitTable
- makeVisitDetectorTable
- consolidateDiaSourceTable
- makeSampledImageSubtractionMetrics
- analyzeSampledImageSubtractionMetrics
Expand Down Expand Up @@ -442,3 +450,6 @@ contracts:
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
makeVisitTable.connections.ConnectionsClass(config=makeVisitTable).visitSummaries.name
msg: "consolidateVisitSummary.visitSummary != makeVisitTable.visitSummaries"
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
makeVisitDetectorTable.connections.ConnectionsClass(config=makeVisitDetectorTable).visitSummaryRefs.name
msg: "consolidateVisitSummary.visitSummary != makeVisitDetectorTable.visitSummaryRefs"
4 changes: 4 additions & 0 deletions pipelines/_ingredients/ApPipeWithPreconvolution.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ subsets:
- analyzePreliminarySummaryStats
- consolidateVisitSummary
- makeVisitTable
- makeVisitDetectorTable
- consolidateDiaSourceTable
- analyzeVisitSampledImageSubtractionMetrics
- aggregateVisitSummary
Expand Down Expand Up @@ -134,3 +135,6 @@ contracts:
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
makeVisitTable.connections.ConnectionsClass(config=makeVisitTable).visitSummaries.name
msg: "consolidateVisitSummary.visitSummary != makeVisitTable.visitSummaries"
- contract: consolidateVisitSummary.connections.ConnectionsClass(config=consolidateVisitSummary).visitSummary.name ==
makeVisitDetectorTable.connections.ConnectionsClass(config=makeVisitDetectorTable).visitSummaryRefs.name
msg: "consolidateVisitSummary.visitSummary != makeVisitDetectorTable.visitSummaryRefs"
Loading