Repository navigation
DM-54951 : Modularize ap_daytime script for CM-Service - #277
tcjennings wants to merge 5 commits into
Conversation
37db766 to
ed5bc27
Compare
8cd71f5 to
6b16bc8
Compare
95dbca6 to
1726e50
Compare
0283889 to
102942e
Compare
102942e to
ddb1b72
Compare
fb6a4b3 to
58f8d76
Compare
58f8d76 to
69bc470
Compare
69bc470 to
1dc0e49
Compare
78f424a to
71d2b3e
Compare
71d2b3e to
0fc1d6e
Compare
6be1807 to
6d74ba4
Compare
14f0730 to
cd0c153
Compare
hsinfang
left a comment
There was a problem hiding this comment.
LGTM; a question about --qgraph-datastore-records.
Should we remove submit_ap_daytime.sh and other now-obsolete files too, now this is run in cm-service?
| - "-c parameters:release_id=1" | ||
| - "-c parameters:apdb_config=s3://embargo@rubin-summit-users/apdb_config/cassandra/pp_apdb_lsstcam.yaml" | ||
| - "-c associateApdb:doRunForcedMeasurement=False" | ||
| - "--dataset-query-constraint off" |
There was a problem hiding this comment.
Comparing this to ap_pipe/scripts/LSSTCam/submit_ap_daytime.sh, --qgraph-datastore-record is left out. Was it intentional?
(https://rubinobs.atlassian.net/browse/DM-55426 may be relevant)
There was a problem hiding this comment.
(though post_isr_image datasets have been generated... )
There was a problem hiding this comment.
The legacy script uses pipetask directly for the qgraph generation, which is why that flag was needed. BPS includes --qgraph-datastore-records in its default set of arguments for pipetask.
CM has never used pipetask for qgraph generation; instead, it used bps acquire to generate the qgraph prior to pruning, so the argument is included by default.
Now CM doesn't separate the acquire/submit stage at all and uses the --prune-... argument to affect the same outcome with an ordinary bps submit, and still relies on the bps defaults to supply --qgraph-datastore-records where needed.
cd0c153 to
8a6dc42
Compare
- separate dynamic contents to separate script - add reference campaigns for cmservice
8a6dc42 to
9a672ed
Compare
Uh oh!
There was an error while loading. Please reload this page.