Repository navigation
DM-55849: allow DECam templates as a secondary choice in PP - #390
Merged
Merged
Conversation
isullivan
approved these changes
Nov 3, 2026
isullivan
left a comment
isullivan
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I had one question about the deleted use of instrument.
|
|
||
|
|
||
| @connect.retry(2, SQL_EXCEPTIONS, wait=repo_retry) | ||
| def get_central_butler(central_repo: str, instrument_class: str, writeable: bool): |
Member
There was a problem hiding this comment.
The instrument_class removed here doesn't look like it was being used at all before. Is this a cleanup unrelated to this ticket, or am I missing something important?
Collaborator
Author
There was a problem hiding this comment.
Completely unrelated to this ticket/DECam templates
Since 1aab548 instrument_class has been a silently ignored parameter.
Commit cc4248a removed the only reader, self.skymap.findTract(center), leaving the attribute loaded but never used.
lsst/ap_pipe@1106b87 has made the same config change upstream and the override is no longer needed.
hsinfang
force-pushed
the
tickets/DM-55849
branch
2 times, most recently
from
November 5, 2026 21:35
2a17de2 to
8097fb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.