Skip to content

fix(stapp): claim external container before first fragment write (closes #752) #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kailigithub wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(stapp): claim external container before first fragment write (closes #752) #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions frontends/stapp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,6 +439,12 @@ def _slash_missing(name):
# Stream hosts only when this session owns the queue.
# Single always-on 1s tick below (stream / detached / hub / idle) — never unregistered.
_stream_fh = _stream_ls = None
# Streamlit >=1.60 raises "A fragment tried to write to a container
# created outside the fragment" when a @st.fragment first writes into
# an external container that hasn't been claimed by a full-app run.
# Claim it once on the first fragment-side write so the position is
# reserved before any expander is folded in. See #752.
_stream_claimed = False
if st.session_state.get('display_queue') is not None:
with st.chat_message("assistant"):
_stream_fh = st.container()
Expand Down Expand Up @@ -475,6 +481,10 @@ def _tick():
frozen = st.session_state.get('_stream_frozen', 0)
while frozen < max(0, len(steps) - 1):
body = steps[frozen] or ''
global _stream_claimed
if not _stream_claimed:
with _stream_fh: st.markdown("")
_stream_claimed = True
with _stream_fh:
with st.expander(_step_title(body, frozen), expanded=False): st.markdown(body)
frozen += 1
Expand Down
Loading