Repository navigation
Add integration tests for JSON literal request bodies - #1728
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds integration tests checking that JSON literals (
false,true, integers, floats,0, arrays, hashes) are correctly encoded as request bodies through the:jsonrequest middleware, plus a pre-encoded JSON string literal and anilbody (no body sent).These validate the change in #1691 (preserving
falserequest bodies inConnection#run_request). Without that fix, thefalseexample fails; the rest pass.Plain
Stringbodies are left untouched by the JSON middleware (assumed already encoded), so strings are tested as pre-encoded JSON ('"hello"').Todos
Additional Notes
Run with
bin/integration-tests spec/integration/json_body_integration_spec.rb.