Repository navigation
Copy header names before retaining them in the case index - #1699
Closed
OskarEichler wants to merge 0 commit into
Closed
OskarEichler wants to merge 0 commit into
OskarEichler wants to merge 0 commit into
Conversation
OskarEichler
force-pushed
the
codex/copy-indexed-header-names
branch
from
August 28, 2026 11:12
b8abc18 to
b25b1b2
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copy names before retaining them in the case-preserving index.
Reproduction and verification
Directly insert with a mutable string key, mutate that caller string, then look up the original lowercase name. Baseline returns nil; the fix retains the header. Verified spelling, case-insensitive replacement and deletion.
Limitations
No test/spec files were added or changed because the originating repository explicitly forbids this. Reproductions ran outside the repository. This differs from Faraday's requested regression-test contribution convention and is disclosed for maintainer review. Other Ruby versions/platforms were not run locally. This PR includes only the focused source change; the other fixes and the consumer's separately verified merged JSON decoder patch #1687 are not added here.
Breaking-change notes
No API change. Caller strings remain mutable; their mutation no longer corrupts the per-header index.