Repository navigation
Preserve literal plus signs when decoding URI userinfo - #1694
Merged
olleolleolle merged 3 commits intoOct 7, 2026
Merged
olleolleolle merged 3 commits into
olleolleolle merged 3 commits into
Conversation
Decode URI userinfo as percent-encoded text without converting literal plus signs to spaces, both for connection URL credentials and proxy options.
olleolleolle
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decode URI userinfo as percent-encoded text without converting literal plus signs to spaces.
Reproduction and verification
Synthetic userinfo u+p:p+ss decodes incorrectly before the fix. Verified literal +, %2B, %20, %252B, %40 and %3A for proxy options and generated Basic headers. No real credentials used. RFC 3986 sections 2.2/3.2.1 permit literal +: https://www.rfc-editor.org/rfc/rfc3986#section-3.2.1
Limitations
No test/spec files were added or changed because the originating repository explicitly forbids this. Reproductions ran outside the repository. This differs from Faraday's requested regression-test contribution convention and is disclosed for maintainer review. Other Ruby versions/platforms were not run locally. This PR includes only the focused source change; the other fixes and the consumer's separately verified merged JSON decoder patch #1687 are not added here.
Breaking-change notes
Literal + now remains +; use %20 for a space. Form/query decoding is unchanged.