Skip to content

Preserve explicit proxy settings when duplicating connections - #1693

Merged
olleolleolle merged 2 commits into
lostisland:mainfrom
OskarEichler:codex/preserve-manual-proxy-on-dup
Oct 7, 2026
Merged

olleolleolle merged 2 commits into
lostisland:mainfrom
OskarEichler:codex/preserve-manual-proxy-on-dup

Conversation

@OskarEichler

Copy link
Copy Markdown
Contributor

Summary

Preserve explicit proxy policy when duplicating connections.

Reproduction and verification

Create a connection with a synthetic proxy URL and duplicate it. Baseline loses the proxy; fixed copy retains host/port and a distinct options object. Explicit proxy=nil also remains disabled on the copy.

  • Individual patch: 7 focused Faraday checks passed (proxy); all 639 existing RSpec examples pass; changed-file RuboCop and Ruby syntax pass.
  • Combined installed-release-based branch: 639 existing examples, 1,124 focused checks, full RuboCop (75 files), YARD checks and gem packaging pass.
  • External faraday-net_http adapter suite: 386 existing examples, zero failures with the combined fixes.
  • Ruby 4.0.6 through rbenv. No production or live external HTTP operations.

Limitations

No test/spec files were added or changed because the originating repository explicitly forbids this. Reproductions ran outside the repository. This differs from Faraday's requested regression-test contribution convention and is disclosed for maintainer review. Other Ruby versions/platforms were not run locally. This PR includes only the focused source change; the other fixes and the consumer's separately verified merged JSON decoder patch #1687 are not added here.

Breaking-change notes

Copies now retain manual proxy settings instead of reverting to default/environment selection. Proxy URI deep mutation semantics are unchanged.

@olleolleolle
olleolleolle force-pushed the codex/preserve-manual-proxy-on-dup branch from 4573f9d to 9be3a58 Compare October 7, 2026 21:34
@olleolleolle
olleolleolle merged commit deeb6ef into lostisland:main Oct 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants