Repository navigation
Preserve caller-owned JSON parser options - #1689
Merged
olleolleolle merged 1 commit intoAug 27, 2026
Merged
olleolleolle merged 1 commit into
olleolleolle merged 1 commit into
Conversation
olleolleolle
approved these changes
Aug 27, 2026
olleolleolle
left a comment
Member
There was a problem hiding this comment.
This change looks good.
The note about the repo not accepting tests read a little strong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duplicate parser options before extracting the decoder.
Reproduction and verification
Construct JSON response middleware twice from the same parser_options hash containing :decoder: baseline deletes the decoder and the second instance falls back to JSON. A frozen options hash raises FrozenError. Both work after the fix.
Limitations
No test/spec files were added or changed because the originating repository explicitly forbids this. Reproductions ran outside the repository. This differs from Faraday's requested regression-test contribution convention and is disclosed for maintainer review. Other Ruby versions/platforms were not run locally. This PR includes only the focused source change; the other fixes and the consumer's separately verified merged JSON decoder patch #1687 are not added here.
Breaking-change notes
No API changes. Initialization stops mutating caller options and snapshots their top-level values.