Skip to content

libvirt_vcpu_plug_unplug: add kdump test after vCPU hotplug/unplug! #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anushree-Mathur wants to merge 1 commit into
base: KVMCI
Choose a base branch
from
+63 −2
Open

libvirt_vcpu_plug_unplug: add kdump test after vCPU hotplug/unplug! #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions libvirt/tests/cfg/libvirt_vcpu_plug_unplug.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,31 @@
vcpu_plug_num = 240
vcpu_unplug_num = 1
vcpu_max_num = 240
- kdump_after_plug_unplug:
# Hotplug vCPUs, trigger kdump, verify vmcore;
# then unplug vCPUs, trigger kdump again, verify
# a new vmcore. Confirms guest kernel stability
# under changing vCPU count.
# Requires kdump service active in the guest.
only live
only ppc64le,ppc64
kdump_after_plug_unplug = "yes"
on_crash = "restart"
crash_dir = "/var/crash/"
vcpu_max_num = "8"
vcpu_current_num = "4"
vcpu_plug_num = "8"
vcpu_unplug_num = "4"
variants:
- hotplug_kdump:
vcpu_plug = "yes"
vcpu_unplug = "no"
- unplug_kdump:
vcpu_plug = "no"
vcpu_unplug = "yes"
- plug_and_unplug_kdump:
vcpu_plug = "yes"
vcpu_unplug = "yes"

variants:
- live:
Expand Down
40 changes: 38 additions & 2 deletions libvirt/tests/src/libvirt_vcpu_plug_unplug.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from virttest import utils_libvirtd
from virttest import utils_test
from virttest.utils_test import libvirt
from virttest import utils_kdump
from virttest.libvirt_xml.vm_xml import VMXML

from provider.cpu import patch_total_cpu_count_s390x
Expand Down Expand Up @@ -240,6 +241,8 @@ def check_setvcpus_result(cmd_result, expect_error):
with_stress = "yes" == params.get("run_stress", "no")
iterations = int(params.get("test_itr", 1))
topology_correction = "yes" == params.get("topology_correction", "no")
kdump_after_plug_unplug = "yes" == params.get("kdump_after_plug_unplug", "no")
crash_dir = params.get("crash_dir", "/var/crash/")
# Init expect vcpu count values
expect_vcpu_num = {'max_config': vcpu_max_num, 'max_live': vcpu_max_num,
'cur_config': vcpu_current_num,
Expand Down Expand Up @@ -356,6 +359,21 @@ def check_setvcpus_result(cmd_result, expect_error):
vcpu_max_timeout, text="wait for vcpu online") or not online_new_vcpu(vm, vcpu_plug_num):
test.fail("Fail to enable new added cpu")

# Trigger kdump after hotplug to verify guest kernel
# stability under the new vCPU count
if kdump_after_plug_unplug:
logging.info("Triggering kdump after vCPU hotplug")
kdump_session = vm.wait_for_login(timeout=240)
utils_kdump.trigger_crash(vm, session=kdump_session,
wait_time=120, test=test)
logging.info("Verifying vmcore generated after hotplug kdump")
pre_vmcores = utils_kdump.get_vmcores(
vm, crash_dir=crash_dir, test=test)
if not pre_vmcores:
test.fail("No vmcore generated after hotplug kdump")
logging.info("vmcore confirmed after hotplug: %s",
pre_vmcores)

# Pin vcpu
if pin_after_plug:
result = virsh.vcpupin(vm_name, pin_vcpu, pin_cpu_list,
Expand Down Expand Up @@ -479,6 +497,21 @@ def check_setvcpus_result(cmd_result, expect_error):
if session:
session.close()

# Trigger kdump after unplug to verify guest kernel
# stability under the reduced vCPU count
if kdump_after_plug_unplug:
logging.info("Triggering kdump after vCPU unplug")
kdump_session = vm.wait_for_login(timeout=240)
utils_kdump.trigger_crash(vm, session=kdump_session,
wait_time=120, test=test)
logging.info("Verifying vmcore generated after unplug kdump")
post_vmcores = utils_kdump.get_vmcores(
vm, crash_dir=crash_dir, test=test)
if not post_vmcores:
test.fail("No vmcore generated after unplug kdump")
logging.info("vmcore confirmed after unplug: %s",
post_vmcores)

check_setvcpus_result(result, status_error)
if setvcpu_option == "--config":
expect_vcpu_num['cur_config'] = vcpu_unplug_num
Expand Down Expand Up @@ -542,8 +575,11 @@ def check_setvcpus_result(cmd_result, expect_error):
if not cpu.check_vcpu_value(vm, expect_vcpu_num, expect_vcpupin, setvcpu_option):
logging.error("Expected vcpu check failed")
result_failed += 1
if vm.uptime() < vm_uptime_init:
test.fail("Unexpected VM reboot detected in between test")
# Skip uptime check when kdump is enabled: kdump intentionally
# crashes and reboots the guest, so a lower uptime is expected.
if not kdump_after_plug_unplug:
if vm.uptime() < vm_uptime_init:
test.fail("Unexpected VM reboot detected in between test")
# Recover env
finally:
if need_mkswap:
Expand Down