Repository navigation
refactor(chat): colocate configuration APIs - #7891
Merged
huangruiteng merged 1 commit intoNov 2, 2026
Merged
huangruiteng merged 1 commit into
huangruiteng merged 1 commit into
Conversation
Signed-off-by: lusendong.6789 <lusendong.6789@bytedance.com> Co-authored-by: TRAE CLI <traecli@bytedance.com>
cocolord
requested review from
huangruiteng,
loopx-agent and
songoow
as code owners
November 2, 2026 10:48
loopx-agent
approved these changes
Nov 2, 2026
loopx-agent
left a comment
Collaborator
There was a problem hiding this comment.
1) 问题定义(为什么改、要解决什么)
- 承接 #7878 与 #7883 的顶层模块收拢重构,将
chat_automation_cadence_api.py、chat_goal_configuration_api.py、chat_machine_configuration_api.py三个内部配置 API 模块移入loopx/chat/命名空间,并继续收紧顶层模块预算(139 -> 136)。
2) 改动摘要(按模块分组)
- 配置 API 模块下沉 (
loopx/chat/automation_cadence_api.py,loopx/chat/goal_configuration_api.py,loopx/chat/machine_configuration_api.py,loopx/presentation/configuration_api.py):移动三个模块至loopx/chat/并更新所有内部引用,不留顶层兼容 shim。 - 架构预算收紧与测试同步 (
tests/architecture/top_level_module_budget.json,tests/test_chat_internal_module_layout.py,tests/**):将max_top_level_modules从139收紧至136,同步更新测试导入与 Stewardexecutor_provider选项断言(包含antigravity)。
3) 逐点审阅结论(架构、语义、正确性、测试、风险)
- 架构与测试一致性:模块边界清晰,
test_chat_internal_module_layout.py明确校验旧顶层路径不可导入且新路径归属正确。
4) 建议修改项(分 P0/P1/P2,带文件路径和行号)
- 无阻塞项。
5) 最终结论(Verdict)
Approved — ready to merge once CI completes (exact head 8adea3ae103327b80d0c531e1fb40acfa85a498a verified).
huangruiteng
merged commit Nov 2, 2026
5343587
into
codex/small-kernel-m1-chat-slice2-20261102
8 of 31 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loopx.chatGoal and boundary
This is the next independently reviewable M1 slice of the accepted small-kernel composition RFC. It removes three Chat-owned assembly modules from the top-level kernel surface and gives configuration composition an explicit package boundary without changing HTTP behavior.
Review this PR against its stacked base branch. It depends on #7883 at
1ab4d610c2b3468f353584a4f68d0ac9c19aa0be.This slice is an ownership and future demand-loading prerequisite; it does not claim a runtime performance improvement.
Validation
origin/codex/small-kernel-m1-chat-slice2-20261102: passed, including 10/10 selected canaries and no manual holdsloopx.chatmodules were present, all former top-level modules were absent,loopx chat --helpworked, and installed Chat HTTP delivery passedThe machine-configuration test now includes the already-shipped
antigravityexecutor option; the stacked base's older expected list was stale, while production behavior is unchanged.Generated frontend assets and local validation dependencies are not part of this diff. This runtime boundary requires normal maintainer review and merge authority; this PR is not self-merge eligible.